bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py by gousaiyang · Pull Request #22619 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

There are two different SimpleQueue types imported (from multiprocessing.queues and queue) in Lib/test/test_genericalias.py, the second one shadowing the first one, making the first one not actually tested. Fix by using different names.

https://bugs.python.org/issue39481

Automerge-Triggered-By: @gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Thanks @gousaiyang for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Sorry, @gousaiyang, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b2c0a43699bd9023a69e3fa554f5488a2e17e278 3.9