bpo-30742 Enabling compiling with VS2015 by dzenanz · Pull Request #2446 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are insufficient to make Python work properly when built with MSVC 14.0 or later. I've rejected the bug on BPO - please continue the discussion there if you feel strongly about this.
@zooba Thanks for the feedback.
These changes are insufficient to make Python work properly when built with MSVC 14.0 or later.
Would you have some additional hints allowing to implement a proper patch ?
Find the issue on bugs.python.org for the port I made for Python 3.5 and see the associated patches.
Issue has been closed rejecting the patch for cpython
terryjreedy added a commit that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace. (cherry picked from commit 0ec57e2)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace. (cherry picked from commit 0ec57e2)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
miss-islington added a commit that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace. (cherry picked from commit 0ec57e2)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
terryjreedy added a commit that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace. (cherry picked from commit 0ec57e2)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
The references from me are actually from the miss-islinton bot. They are an accident because when copying the current title line when merging PR 24469, I omitted the 9, so when miss-islington was processing the backports, it had the wrong original number.
adorilson pushed a commit to adorilson/cpython that referenced this pull request
These 3 statements cannot be used at module scope -- nor in exec with one namespace.