bpo-28556: Fix regression that sneaked into recent typing updates by ilevkivskyi · Pull Request #270 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ilevkivskyi

Unfortunately, recent update to typing module introduced a bug: ABC registry of a generic type gets completely wiped out on every subscription. This PR fixes the problem.

@ilevkivskyi

@ilevkivskyi

This needs to be backported to 3.5 and 3.6 after the corresponding cherry-pick PRs #268 and #269 are merged.

Mariatta

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request

Feb 24, 2017

@ilevkivskyi @Mariatta

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request

Feb 24, 2017

@ilevkivskyi @Mariatta

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 13, 2021

Stackless now uses an unmodified PyFrameObject structure. The field PyFrameObject.f_executing now stores the information how to evaluate a frame.

Additional consequences:

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 14, 2021

Consistent usage of SLP_FRAME_EXECUTING_VALUE

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 14, 2021

Cleanups and minor improvements. Fix _PyEval_EvalFrameDefault

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 14, 2021

Again minor improvements.

akruis added a commit to akruis/cpython that referenced this pull request

Jun 18, 2021

@akruis

Stackless now uses an unmodified PyFrameObject structure. The field PyFrameObject.f_executing now stores the information how to evaluate a frame.

Additional consequences:

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 18, 2021

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 20, 2021

Fix test_sys.SizeofTest.test_objecttypes for frames. Stackless has now again the same frame size as C-Python.

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 20, 2021

Integrate the C-function PyEval_EvalFrameEx_slp into into the C-function slp_eval_frame_value and rename slp_eval_frame_value to PyEval_EvalFrameEx_slp.

Adapt the gdb support library and document the change.

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 22, 2021

Back to PyEval_EvalFrameEx_slp and slp_eval_frame_value. But without duplicated code. Revert the gdb changes from the previous commit.

akruis added a commit to akruis/cpython that referenced this pull request

Jun 22, 2021

@akruis

Eliminate duplicated code in ceval.c to improve maintainability. Update changelog.txt.

jaraco pushed a commit that referenced this pull request

Dec 2, 2022

@zware @maxking

"@" usually doesn't give any information about what exactly the handle means since we don't know it is a Github handle from the commit message.

Changing the pattern to be GH: similar to what we do for Pull Requests with (GH-).

Fixes #270

...when automerge label is removed by a core-dev.

Co-authored-by: Abhilash Raj raj.abhilash1@gmail.com