bpo-44958: Only reset sqlite3 statements when needed by erlend-aasland · Pull Request #27844 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation25 Commits16 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This was referenced
Aug 19, 2021
Erlend E. Aasland added 3 commits
FYI, tested with SQLite 3.7.15 (minimum required by CPython), 3.8.0, 3.19.0, 3.19.3, 3.20.0 (SQLITE_STMTSTATUS_RUN added), and 3.37.0 (current dev release).
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit cbcd640 🤖
If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit fe0fd6f 🤖
If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
The AMD64 Arch Linux Asan Debug PR buildbot failure seems to be unrelated. I see that it's been failing a lot recently.
Erlend E. Aasland added 2 commits
PTAL. The merge was non-trivial. I suggest running the buildbots again.
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 06e242c 🤖
If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
FYI, we need #27942 for the buildbots to succeed.
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 9684593 🤖
If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
All buildbots but AMD64 Arch Linux Asan Debug PR succeeded. AMD64 Arch Linux Asan Debug PR failed the compile step with RuntimeError: subprocess not supported for isolated subinterpreters, but it has done so the last 18 days.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Erlend E. Aasland added 2 commits
Thanks for reviewing, Pablo!
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request
Modify managed_connect() helper to support in-memory databases. Use it for the regression tests added in pythonGH-27844.
miss-islington pushed a commit that referenced this pull request
Modify managed_connect() helper to support in-memory databases. Use it for the regression tests added in GH-27844.
Automerge-Triggered-By: GH:pablogsal
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request
This reverts commit 050d103, but keeps the tests.
pablogsal pushed a commit that referenced this pull request
This reverts commit 050d103, but keeps the tests.