bpo-45457: Minor fix to documentation for SSLContext.load_default_certs. by LincolnPuzey · Pull Request #28947 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this,
this fix corrects the documentation to match that change.

https://bugs.python.org/issue45457

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this, this fix corrects the documentation to match that change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc fix!

@tiran Anything else I need to do to get this merged?

Thanks @LincolnPuzey for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 2, 2021

…ts. (pythonGH-28947)

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this, this fix corrects the documentation to match that change. (cherry picked from commit 3551bf1)

Co-authored-by: LincolnPuzey lincoln@puzey.dev

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 2, 2021

…ts. (pythonGH-28947)

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this, this fix corrects the documentation to match that change. (cherry picked from commit 3551bf1)

Co-authored-by: LincolnPuzey lincoln@puzey.dev

ambv pushed a commit that referenced this pull request

Nov 2, 2021

…ts. (GH-28947) (GH-29373)

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this, this fix corrects the documentation to match that change. (cherry picked from commit 3551bf1)

Co-authored-by: LincolnPuzey lincoln@puzey.dev

ambv pushed a commit that referenced this pull request

Nov 2, 2021

…ts. (GH-28947) (GH-29374)

Specify that SSLContext.set_default_verify_paths is called on ALL systems.

The code of SSLContext.load_default_certs was changed in bpo-22449 to do this, this fix corrects the documentation to match that change. (cherry picked from commit 3551bf1)

Co-authored-by: LincolnPuzey lincoln@puzey.dev