bpo-46659: test.support avoids locale.getdefaultlocale() by vstinner · Pull Request #31167 · python/cpython (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

python / cpython Public

• Notifications You must be signed in to change notification settings

• Fork34.4k

• Star 72.3k

• Code

• Issues 5k+

• Pull requests 2.1k

• Actions

• Projects

• Security and quality

• Insights

Additional navigation options

Merged

vstinner merged 1 commit intopython:mainfrom

vstinner:support_getdefaultlocale

Feb 6, 2022

ConversationCommits (1)ChecksFiles changed

Merged

bpo-46659: test.support avoids locale.getdefaultlocale()#31167

vstinner merged 1 commit intopython:mainfrom

vstinner:support_getdefaultlocale

Conversation

Copy link Copy Markdown

Member

vstinner commented

Feb 6, 2022

•

edited by bedevere-bot

Loading

skip_if_buggy_ucrt_strfptime() of test.support now uses
locale.getpreferredencoding(False) instead of
locale.getdefaultlocale() to get the Windwos code page.

https://bugs.python.org/issue46659

`bpo-46659[: test.support avoids locale.getdefaultlocale()](/python/cpython/pull/31167/commits/bd50ee5421f0ec9f751fd12479fbeebae3752f5d "bpo-46659: test.support avoids locale.getdefaultlocale()

skip_if_buggy_ucrt_strfptime() of test.support now uses locale.getpreferredencoding(False) instead of locale.getdefaultlocale() to get the Windwos code page.") `

[bd50ee5](/python/cpython/pull/31167/commits/bd50ee5421f0ec9f751fd12479fbeebae3752f5d)

skip_if_buggy_ucrt_strfptime() of test.support now uses locale.getpreferredencoding(False) instead of locale.getdefaultlocale() to get the Windwos code page.

vstinner added the skip news label

Feb 6, 2022

the-knights-who-say-ni added the CLA signed label

Feb 6, 2022

bedevere-bot added the awaiting core review label

Feb 6, 2022

vstinner merged commit 06b8f16 into python:main

Feb 6, 2022

vstinner deleted the support_getdefaultlocale branch

February 6, 2022 20:51

bedevere-bot removed the awaiting core review label

Feb 6, 2022

vstinner mentioned this pull request

Dec 11, 2022

Deprecate locale.getdefaultlocale() function#90817

Closed

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants