bpo-30737: Update link to the Devguide by bugzPDX · Pull Request #3228 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bugzPDX.
There is a merge conflict, so that has to be addressed.
Also, can drop the .html from new urls.
| @@ -7,7 +7,7 @@ available https://docs.python.org/dev/download.html`_. |
|---|
| Documentation on authoring Python documentation, including information about |
| both style and markup, is available in the "`Documenting Python |
| https://docs.python.org/devguide/documenting.html`_" chapter of the |
| https://devguide.python.org/documenting.html`_" chapter of the |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be dev.guide.python.org/documenting/ (without the .html)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
| @@ -67,7 +67,7 @@ Building Python |
|---|
| If you want to compile CPython yourself, first thing you should do is get the |
| `source https://www.python.org/downloads/source/`_. You can download either the |
| latest release's source or just grab a fresh `clone |
| https://docs.python.org/devguide/setup.html#getting-the-source-code`_. (If you want |
| https://devguide.python.org/setup.html#getting-the-source-code`_. (If you want |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
bpo-3037: Update link to the Devguide bpo-30737: Update link to the Devguide
I changed the bpo number to the correct one :)
The Devguide has a new url so all the old links are updated.
Fix url endings by removing .html and update urls to use https.
The changes look good now, and no longer showing diffs of unrelated commit.
Thanks @bugzPDX and congrats on your first contribution to CPython 🌮
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request
- 'master' of https://github.com/python/cpython: (601 commits) remove check for bug last seem in Solaris 9 (python#3285) Change code owners for hashlib and ssl to the crypto team (python#3284) bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208) remove autoconf check for select() (python#3283) remove configure check for 'volatile' (python#3281) Add missing _sha3 module to Setup.dist (python#2395) bpo-12383: Also ignore PYVENV_LAUNCHER (python#3278) bpo-9146: add the missing NEWS entry. (python#3275) Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270) bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076) remove a redundant lower in urllib.parse.urlsplit (python#3008) bpo-31323: Fix reference leak in test_ssl (python#3263) bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264) bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265) bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560) bpo-31250, test_asyncio: fix dangling threads (python#3252) bpo-31217: Fix regrtest -R for small integer (python#3260) bpo-30096: Use ABC in abc reference examples (python#1220) bpo-30737: Update DevGuide links to new URL (pythonGH-3228) [Trivial] Remove now redundant assert (python#3245) ...
🐍🍒⛏🤖 Thanks @bugzPDX for the PR, and @Mariatta for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Mariatta pushed a commit that referenced this pull request
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request
