bpo-31330: Clarify that multiple new lines are reduced to one. by elenaoat · Pull Request #3272 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
| including argument descriptions. |
|---|
| including argument descriptions. However, multiple new lines in epilog and |
| description are replaced with one. If you prefer to use multiple new lines, |
| add white space between the new line characters. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to mention epilog and description here. It sounds like all instances of adjacent newlines are turned into single newlines.
I would phrase the last sentence: "If you wish to preserve multiple blank lines, add spaces between the newlines.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the requested changes.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
🐍🍒⛏🤖 Thanks @elenaoat for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
… newlines. (pythonGH-3272)
Also provide a solution if the user wants to keep multiple blank lines. (cherry picked from commit 397c467)
🐍🍒⛏🤖 Thanks @elenaoat for the PR, and @bitdancer for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
… newlines. (pythonGH-3272)
Also provide a solution if the user wants to keep multiple blank lines. (cherry picked from commit 397c467)
bitdancer pushed a commit that referenced this pull request
… newlines. (GH-3272) (GH-3428)
Also provide a solution if the user wants to keep multiple blank lines. (cherry picked from commit 397c467)
bitdancer pushed a commit that referenced this pull request
… newlines. (GH-3272) (GH-3429)
Also provide a solution if the user wants to keep multiple blank lines. (cherry picked from commit 397c467)