bpo-31036: Allow sphinx and blurb to be found automatically by ned-deily · Pull Request #3440 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits9 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ned-deily

Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time.

https://bugs.python.org/issue31036

@larryhastings

Brett's done all the reviewing so far, but he's on vacation from Python this month. I don't mind reviewing it but I'm likely to just rubber-stamp it. I can do that if that's what you want ;-)

benjaminp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

innocuous enough

@miss-islington

🐍🍒⛏🤖 Thanks @ned-deily for the PR, and @ned-deily for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 8, 2017

@ned-deily @miss-islington

…thonGH-3440)

Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the make venv target. (cherry picked from commit 590665c)

@bedevere-bot

ned-deily pushed a commit that referenced this pull request

Sep 8, 2017

@miss-islington @ned-deily

…-3440) (#3441)

Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the make venv target. (cherry picked from commit 590665c)

ned-deily added a commit that referenced this pull request

Sep 8, 2017

@ned-deily

…-3440)

Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the make venv target.

@miss-islington

Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

Sorry, @ned-deily, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 590665c399fc4aa3c4a9f8e7104d43a02e9f3a0c 2.7

benjaminp pushed a commit that referenced this pull request

Oct 8, 2019

@ned-deily @benjaminp

…-3440)

Rather than requiring the path to blurb and/or sphinx-build to be specified to the make rule, enhance the Doc/Makefile to look for each first in a virtual environment created by make venv and, if not found, look on the normal process PATH. This allows the Doc/Makefile to take advantage of an installed spinx-build or blurb and, thus, do the right thing most of the time. Also, make the directory for the venv be configurable and document the make venv target.. (cherry picked from commit 590665c)

Co-authored-by: Ned Deily nad@python.org