bpo-31234: Enhance test_thread.test_forkinthread() by vstinner · Pull Request #3516 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit
  346cbd3 (bpo-16500,
  os.register_at_fork(), os.fork() cannot fail anymore with
  RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing
  the platform.

https://bugs.python.org/issue31234

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit 346cbd3 (bpo-16500, os.register_at_fork(), os.fork() cannot fail anymore with RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing the platform.

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 12, 2017

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit 346cbd3 (bpo-16500, os.register_at_fork(), os.fork() cannot fail anymore with RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing the platform. (cherry picked from commit a15d155)

vstinner pushed a commit that referenced this pull request

Sep 12, 2017

…3519)

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit 346cbd3 (bpo-16500, os.register_at_fork(), os.fork() cannot fail anymore with RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing the platform. (cherry picked from commit a15d155)