[3.6] bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0 by vstinner · Pull Request #3518 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 3 commits intopython:3.6fromvstinner:fall_through36

Sep 12, 2017

Merged

[3.6] bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0 #3518

vstinner merged 3 commits intopython:3.6fromvstinner:fall_through36

Sep 12, 2017

Conversation5 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Copy link

Member

@vstinner vstinner commented

Sep 12, 2017

•

edited by bedevere-bot

bpo-30923: Disable warning that has been part of -Wextra since gcc-7.0. (bpo-30923: Disable warning that has been part of -Wextra since gcc-7.0. #3142)
bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0. (bpo-30923: Silence fall-through warnings included in -Wextra since gc… #3157)
bpo-31275: Small refactoring to silence a fall-through warning. (bpo-31275: Small refactoring to silence a fall-through warning. #3206)

https://bugs.python.org/issue30923

Stefan Krah added 3 commits

September 12, 2017 19:37

`bpo-30923[: Disable warning that has been part of -Wextra since gcc-7.…](/python/cpython/pull/3518/commits/cb4e97f8393fe1fa274386e9ffbb6cda03570a11 "bpo-30923: Disable warning that has been part of -Wextra since gcc-7.0. (#3142)

(cherry picked from commit d73a960c575207539c3f9765cff26d4fff400b45)") `

[cb4e97f](/python/cpython/pull/3518/commits/cb4e97f8393fe1fa274386e9ffbb6cda03570a11)

…0. (#3142)

(cherry picked from commit d73a960)

`bpo-30923[: Silence fall-through warnings included in -Wextra since gc…](/python/cpython/pull/3518/commits/0dad95f85276ea6fc0985997b3a22d1ba42391f3 "bpo-30923: Silence fall-through warnings included in -Wextra since gcc-7.0. (#3157)

(cherry picked from commit f432a3234f9f2ee09bd40be03e06bf72865ee375)") `

[0dad95f](/python/cpython/pull/3518/commits/0dad95f85276ea6fc0985997b3a22d1ba42391f3)

…c-7.0. (#3157)

(cherry picked from commit f432a32)

`bpo-31275[: Small refactoring to silence a fall-through warning. (](/python/cpython/pull/3518/commits/8fc22d6d32a87ed50dd8be779a448ad5538e03d3 "bpo-31275: Small refactoring to silence a fall-through warning. (#3206)

(cherry picked from commit 138753c1b96b5e06a5c5d409fa4cae5e2fe1108b)")#3206[)](/python/cpython/pull/3518/commits/8fc22d6d32a87ed50dd8be779a448ad5538e03d3 "bpo-31275: Small refactoring to silence a fall-through warning. (#3206)

(cherry picked from commit 138753c1b96b5e06a5c5d409fa4cae5e2fe1108b)") `

[8fc22d6](/python/cpython/pull/3518/commits/8fc22d6d32a87ed50dd8be779a448ad5538e03d3)

(cherry picked from commit 138753c)

vstinner requested a review from skrah

September 12, 2017 17:39

the-knights-who-say-ni added the CLA signed label

Sep 12, 2017

bedevere-bot added the awaiting merge label

Sep 12, 2017

vstinner added the skip news label

Sep 12, 2017

Copy link

Member

serhiy-storchaka commented

Sep 12, 2017

Usually we don't backport changes that just silence compiler warnings.

Copy link

Contributor

skrah commented

Sep 12, 2017

It's a double edged sword: If we don't backport, other backports become more difficult because of conflicts. Technically we should take out _codecs_iso2022.c, but I assume that @Haypo has given it another thorough look.