bpo-31234: Try to fix lock_tests warning by vstinner · Pull Request #3557 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

Try to fix the "Warning -- threading_cleanup() failed to cleanup 1
threads" warning in test.lock_tests: wait a little bit longer to give
time to the threads to complete.

Warning seen on test_thread and test_importlib.

https://bugs.python.org/issue31234

@vstinner

Try to fix the "Warning -- threading_cleanup() failed to cleanup 1 threads" warning in test.lock_tests: wait a little bit longer to give time to the threads to complete.

Warning seen on test_thread and test_importlib.

vstinner added a commit that referenced this pull request

Jun 1, 2018

@vstinner

)

Use _thread.count() to wait until threads exit. The new context manager prevents the "dangling thread" warning.

(cherry picked from commit ff40ecd)

Try to fix the "Warning -- threading_cleanup() failed to cleanup 1 threads" warning in test.lock_tests: wait a little bit longer to give time to the threads to complete.

Warning seen on test_thread and test_importlib.

(cherry picked from commit 096ae33)