bpo-31457: Don't omit inner process() calls with nested LogAdapters by ambv · Pull Request #4044 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ambv

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added.

https://bugs.python.org/issue31457

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added.

vsajip

@miss-islington

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 19, 2017

@ambv @miss-islington

…rs (pythonGH-4044)

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added. (cherry picked from commit ce9e625)

Mariatta pushed a commit that referenced this pull request

Oct 19, 2017

@miss-islington @Mariatta

…rs (GH-4044) (GH-4050)

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added. (cherry picked from commit ce9e625)

@miss-islington

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 22, 2018

@ambv @miss-islington

…rs (pythonGH-4044)

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added. (cherry picked from commit ce9e625)

Co-authored-by: Łukasz Langa lukasz@langa.pl

@bedevere-bot

ambv added a commit that referenced this pull request

Apr 22, 2018

@miss-islington @ambv

…rs (GH-4044) (#6568)

This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the log() method of LogAdapter call logger._log() directly. This makes nested log adapters not execute their process() method. This patch fixes the issue.

Also, now proxying name, too, to make repr() work with nested log adapters.

New tests added. (cherry picked from commit ce9e625)

Co-authored-by: Łukasz Langa lukasz@langa.pl

@ambv ambv deleted the nestedfixfixfix branch

July 12, 2021 11:23