[backport to 2.7] Change documentation's Show Source link to GitHub by Mariatta · Pull Request #44 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Change documentation's Show Source link to GitHub (2.7 branch)
Render issue role as bpo-NNNN
Change the url to 2.7
(cherry picked from commit 79ab8be)
| @@ -58,7 +58,7 @@ def new_depart_literal_block(self, node): |
|---|
| def issue_role(typ, rawtext, text, lineno, inliner, options={}, content=[]): |
| issue = utils.unescape(text) |
| text = 'issue ' + issue |
| text = 'bpo- ' + issue |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there space between 'bpo-' and issue number?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there shouldn't be a space 😅
Thanks for the review :) Will fix soon.
Hm, the title of pull request is bit misleading. doc of Python 2.7 doesn't include Misc/NEWS.
But this pull request backports these changes.
- Change link target of "Source code:" from hg.python.org to github
- issue role (
:issue:`1234`) rendered as "bpo-1234" instead of "issue 1234" (example)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did make html in local, and it works as expected.
LGTM.
[backport to 2.7] Support "bpo-" in Misc/NEWS [backport to 2.7] Change documentation's Show Source link to GitHub
Thanks @methane :) I updated the pull request description.
What do you think?
gnprice added a commit to gnprice/cpython that referenced this pull request
benjaminp pushed a commit that referenced this pull request
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
benjaminp pushed a commit that referenced this pull request
The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications
Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7)
Co-authored-by: Greg Price gnprice@gmail.com
benjaminp added a commit that referenced this pull request
The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications
Change the link to one that points to the current version. Also, use HTTPS.. (cherry picked from commit 64c6ac7)
Co-authored-by: Greg Price gnprice@gmail.com
miss-islington added a commit that referenced this pull request
The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications
Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7)
Co-authored-by: Greg Price gnprice@gmail.com
miss-islington added a commit that referenced this pull request
The link we have points to the version from Unicode 6.0.0, dated 2010. There have been numerous updates to it since then: https://www.unicode.org/reports/tr44/GH-Modifications
Change the link to one that points to the current version. Also, use HTTPS. (cherry picked from commit 64c6ac7)
Co-authored-by: Greg Price gnprice@gmail.com
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request
iritkatriel referenced this pull request in iritkatriel/cpython
jaraco pushed a commit to jaraco/cpython that referenced this pull request
Fix contents() so that it no longer returns unrelated items
Closes python#44
See merge request python-devs/importlib_resources!48
oraluben pushed a commit to oraluben/cpython that referenced this pull request
This was referenced
Feb 11, 2025