bpo-12382: Make OpenDatabase() raise better exception messages by berkerpeksag · Pull Request #4528 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

berkerpeksag

Previously, 'msilib.OpenDatabase()' function raised a
cryptical exception message when it couldn't open or
create an MSI file. For example:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_msi.MSIError: unknown error 6e

https://bugs.python.org/issue12382

@berkerpeksag

Previously, 'msilib.OpenDatabase()' function raised a cryptical exception message when it couldn't open or create an MSI file. For example:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_msi.MSIError: unknown error 6e

@miss-islington

Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 24, 2017

@berkerpeksag @miss-islington

…nGH-4528)

Previously, 'msilib.OpenDatabase()' function raised a cryptical exception message when it couldn't open or create an MSI file. For example:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_msi.MSIError: unknown error 6e

(cherry picked from commit 4864a61)

berkerpeksag pushed a commit that referenced this pull request

Nov 24, 2017

@miss-islington @berkerpeksag

Previously, 'msilib.OpenDatabase()' function raised a cryptical exception message when it couldn't open or create an MSI file. For example:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
_msi.MSIError: unknown error 6e

(cherry picked from commit 4864a61)