bpo-27122: Fix comment to point to correct issue # by njsmith · Pull Request #47 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

njsmith

@njsmith

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449

@codecov

Codecov Report

Merging #47 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #47 +/- ##


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2294f3a...a4f3401. Read the comment docs.

berkerpeksag

berkerpeksag pushed a commit that referenced this pull request

Feb 12, 2017

@njsmith @berkerpeksag

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

@berkerpeksag

Thanks! I've created #48 and #50 to backport this to maintenance branches.

@Mariatta Mariatta changed the titleFix comment to point to correct issue # bpo-27122: Fix comment to point to correct issue #

Feb 13, 2017

@ghost ghost mentioned this pull request

Sep 24, 2017

iritkatriel referenced this pull request in iritkatriel/cpython

Jul 23, 2021

@iritkatriel

jaraco pushed a commit that referenced this pull request

Dec 2, 2022

@pyup-bot @Mariatta

isidentical referenced this pull request in isidentical/cpython

Mar 22, 2023

@pablogsal

oraluben pushed a commit to oraluben/cpython that referenced this pull request

Jun 27, 2023

@Fidget-Spinner

This was referenced

Feb 11, 2025