bpo-28955: Clarified comparisons between NaN and number in reference documentation by TonyFlury · Pull Request #5982 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
CLA signed - 11:10am GMT - 4th March 2018
| @@ -0,0 +1 @@ |
|---|
| Issue 28955 - Clarified numeric comparisons with NaN. Patch by Tony Flury |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't require news entries for trivial documentation changes. You can delete this file.
| will return ``False``. For example, both ``3 < float('NaN')`` and |
|---|
| ``float('NaN') < 3`` will return ``False``. |
| ``float('NaN') < 3`` will return ``False``. This is compliant with IEE 754. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be IEEE 754?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
| will return ``False``. For example, both ``3 < float('NaN')`` and |
|---|
| ``float('NaN') < 3`` will return ``False``. |
| ``float('NaN') < 3`` will return ``False``. This is compliant with IEE 754. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style nit: Please start a new sentence with two spaces. See line 1338 for example:
...
are special. They are identical to themselves (x is x is true) but
...
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
bpo-28955 : Clarified comparisons between Nan and number in reference… bpo-28955: Clarified comparisons between NaN and number in reference documentation
I have made the requested changes; please review again.
Thanks for making the requested changes!
@berkerpeksag: please review the changes made to this pull request.
Thanks @TonyFlury for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
…erence documentation (pythonGH-5982)
Co-authored-by: Benjamin Peterson benjamin@python.org (cherry picked from commit ad8a000)
Co-authored-by: Tony Flury anthony.flury@btinternet.com
miss-islington added a commit that referenced this pull request
…erence documentation (GH-5982)
Co-authored-by: Benjamin Peterson benjamin@python.org (cherry picked from commit ad8a000)
Co-authored-by: Tony Flury anthony.flury@btinternet.com