bpo-28055: fix unaligned accesses in siphash24() by DerDakon · Pull Request #6123 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open an issue on the bug tracker for discussion.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
fix unaligned accesses in siphash24() bpo-28055: fix unaligned accesses in siphash24()
| v3 ^= mi; |
|---|
| DOUBLE_ROUND(v0,v1,v2,v3); |
| v0 ^= mi; |
| } |
| t = 0; |
| pt = (uint8_t *)&t; |
| m = (uint8_t *)in; |
| m = in; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m is not needed. Just use in.
So other than a NEWS entry, is there anything else that needs to be done for this before merging?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a news entry is needed.
| @@ -0,0 +1 @@ |
|---|
| fix unaligned accesses in siphash24() |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start the sentence from the title case, add missed period, and please add "Patch by yourname."
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
The hash implementation casts the input pointer to uint64_t* and directly reads from this, which may cause unaligned accesses. Use memcpy() instead so this code will not crash with SIGBUS on sparc.
https://bugs.gentoo.org/show_bug.cgi?id=636400
Thanks @DerDakon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
The hash implementation casts the input pointer to uint64_t* and directly reads from this, which may cause unaligned accesses. Use memcpy() instead so this code will not crash with SIGBUS on sparc.
https://bugs.gentoo.org/show_bug.cgi?id=636400 (cherry picked from commit 1e2ec8a)
Co-authored-by: Rolf Eike Beer eike@sf-mail.de
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
The hash implementation casts the input pointer to uint64_t* and directly reads from this, which may cause unaligned accesses. Use memcpy() instead so this code will not crash with SIGBUS on sparc.
https://bugs.gentoo.org/show_bug.cgi?id=636400 (cherry picked from commit 1e2ec8a)
Co-authored-by: Rolf Eike Beer eike@sf-mail.de
miss-islington added a commit that referenced this pull request
The hash implementation casts the input pointer to uint64_t* and directly reads from this, which may cause unaligned accesses. Use memcpy() instead so this code will not crash with SIGBUS on sparc.
https://bugs.gentoo.org/show_bug.cgi?id=636400 (cherry picked from commit 1e2ec8a)
Co-authored-by: Rolf Eike Beer eike@sf-mail.de
miss-islington added a commit that referenced this pull request
The hash implementation casts the input pointer to uint64_t* and directly reads from this, which may cause unaligned accesses. Use memcpy() instead so this code will not crash with SIGBUS on sparc.
https://bugs.gentoo.org/show_bug.cgi?id=636400 (cherry picked from commit 1e2ec8a)
Co-authored-by: Rolf Eike Beer eike@sf-mail.de
matoro added a commit to matoro/cpython that referenced this pull request
Like python#6123 this pointer may be unaligned, so a memcpy() instead of simple assignment is required for strict architectures e.g. sparc.
Labels
An unexpected behavior, bug, or error