bpo-33100: Dataclasses now handles slots and default values correctly. by ericvsmith · Pull Request #6152 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 20, 2018

…ctly. (pythonGH-6152)

If the class has a member that's a MemberDescriptorType, it's not a default value, it's from that member being in slots. (cherry picked from commit 7389fd9)

Co-authored-by: Eric V. Smith ericvsmith@users.noreply.github.com

ericvsmith added a commit that referenced this pull request

Mar 20, 2018

…ctly. (GH-6152) (GH-6153)

If the class has a member that's a MemberDescriptorType, it's not a default value, it's from that member being in slots. (cherry picked from commit 7389fd9)

Co-authored-by: Eric V. Smith ericvsmith@users.noreply.github.com

jo2y pushed a commit to jo2y/cpython that referenced this pull request

Mar 23, 2018

…ctly. (pythonGH-6152)

If the class has a member that's a MemberDescriptorType, it's not a default value, it's from that member being in slots.