bpo-33642: IDLE: Use variable number of lines in CodeContext. by csabella · Pull Request #7106 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

csabella

@csabella

terryjreedy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending coordination with other issues, I think this is ready.

@miss-islington

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 1, 2018

@csabella @miss-islington

…GH-7106)

Instead of displaying a fixed number of lines, some blank, Code Context now displays the variable number of actual context lines. When there are no context lines, it shows a single blank line to indicate that the feature is turned on.

The Code Context configuration option is changed from 'numlines' (default 3) to 'maxlines' (default 15) to avoid possible interference between user settings for the old and new versions of Code Context. (cherry picked from commit 29996a1)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 1, 2018

@csabella @miss-islington

…GH-7106)

Instead of displaying a fixed number of lines, some blank, Code Context now displays the variable number of actual context lines. When there are no context lines, it shows a single blank line to indicate that the feature is turned on.

The Code Context configuration option is changed from 'numlines' (default 3) to 'maxlines' (default 15) to avoid possible interference between user settings for the old and new versions of Code Context. (cherry picked from commit 29996a1)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

miss-islington added a commit that referenced this pull request

Jun 1, 2018

@miss-islington @csabella

Instead of displaying a fixed number of lines, some blank, Code Context now displays the variable number of actual context lines. When there are no context lines, it shows a single blank line to indicate that the feature is turned on.

The Code Context configuration option is changed from 'numlines' (default 3) to 'maxlines' (default 15) to avoid possible interference between user settings for the old and new versions of Code Context. (cherry picked from commit 29996a1)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

miss-islington added a commit that referenced this pull request

Jun 2, 2018

@miss-islington @csabella

Instead of displaying a fixed number of lines, some blank, Code Context now displays the variable number of actual context lines. When there are no context lines, it shows a single blank line to indicate that the feature is turned on.

The Code Context configuration option is changed from 'numlines' (default 3) to 'maxlines' (default 15) to avoid possible interference between user settings for the old and new versions of Code Context. (cherry picked from commit 29996a1)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com