bpo-33648: remove PY_WARN_ON_C_LOCALE by grimreaper · Pull Request #7114 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits7 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

grimreaper

@ncoghlan

@methane

@grimreaper

hrm... a regen results in new unexpected changes. It seems someone ran a regen with a different set o tools than I do ?

@grimreaper

Ah, I see

-[m4_define([PKG_MACROS_VERSION], [0.29.2])
+[m4_define([PKG_MACROS_VERSION], [0.29.1])

I'll try and fix this

@grimreaper

This code does not appear to be used anywhere in the python code base. The use was removed in eb81795.

@grimreaper

@grimreaper

@grimreaper

@grimreaper

@grimreaper

@methane

@miss-islington

Thanks @grimreaper for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 11, 2018

@grimreaper @miss-islington

This code does not appear to be used anywhere in the python code base. The use was removed in eb81795. (cherry picked from commit b91a3a0)

Co-authored-by: Eitan Adler grimreaper@users.noreply.github.com

@bedevere-bot

miss-islington added a commit that referenced this pull request

Jul 11, 2018

@miss-islington @grimreaper

This code does not appear to be used anywhere in the python code base. The use was removed in eb81795. (cherry picked from commit b91a3a0)

Co-authored-by: Eitan Adler grimreaper@users.noreply.github.com

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 14, 2018

@CuriousLearner

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 15, 2018

@CuriousLearner

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jul 21, 2018

@CuriousLearner

…ssue-33014