bpo-23859: Document that asyncio.wait() does not cancel its futures by elprans · Pull Request #7217 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Unlike asyncio.wait_for(), asyncio.wait() does not cancel the passed
futures when a timeout accurs.
1st1 approved these changes May 29, 2018
@1st1: Please replace # with GH- in the commit message next time. Thanks!
Thanks @elprans for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Unlike asyncio.wait_for(), asyncio.wait() does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)
Co-authored-by: Elvis Pranskevichus elvis@magic.io
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Unlike asyncio.wait_for(), asyncio.wait() does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)
Co-authored-by: Elvis Pranskevichus elvis@magic.io
| @@ -764,6 +764,9 @@ Task functions | | | | -------------------------------------------------------------------------------- | -------------------------------- | | | | | futures finish or are cancelled. | | | +-----------------------------+----------------------------------------+ | | | | | | | | Unlike :func:`~asyncio.wait_for`, ``wait()`` will not cancel the futures | | | | when a timeout accurs. | | |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: occurs, no?
elprans added a commit to elprans/cpython that referenced this pull request
1st1 pushed a commit that referenced this pull request
1st1 pushed a commit that referenced this pull request
Unlike asyncio.wait_for(), asyncio.wait() does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)
Co-authored-by: Elvis Pranskevichus elvis@magic.io
- Update asyncio-task.rst