bpo-33922: Adding documentation for new "-64" suffix of python launcher by mrh1997 · Pull Request #7849 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some readability improvements, but there's one particular section that is out of date so let's update the whole section now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
since bpo-30291 it is possible to specify as bit length of the python version to be not only 32-bit but alternatively to be 64-bit.
I have made the requested changes; please review again
Thanks for making the requested changes!
@zooba: please review the changes made to this pull request.
For what it's worth, when you force push an update it means I can't review your changes and have to re-review the whole thing again. We always squash and edit commit messages, which means the final result looks neat no matter how many commits it took to get there.
Thanks for the improvements!
Thanks @mrh1997 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
…er (pythonGH-7849)
Since bpo-30291 it is possible to specify the architecture of Python when using the launcher (cherry picked from commit 1e2ad6c)
Co-authored-by: mrh1997 mrh1997@users.noreply.github.com
miss-islington added a commit that referenced this pull request
…er (GH-7849)
Since bpo-30291 it is possible to specify the architecture of Python when using the launcher (cherry picked from commit 1e2ad6c)
Co-authored-by: mrh1997 mrh1997@users.noreply.github.com