bpo-34604: Fix possible mojibake in pwd.getpwnam and grp.getgrnam by william-gr · Pull Request #9098 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@vstinner here is the follow up PR as discussed in #7081

Please let me know if thats what you were meaning.

Thanks!

The build failed probably because I changed pwd.getpwnam signature from arg: unicode to name: unicode, however I am unsure how to fix that. Investigating.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind to add "... in the error message." to clarify that it doesn't affect the regular case?

Thanks @william-gr for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

Thanks @william-gr for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Sorry, @william-gr and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 28658485a54ad5f9df52ecc12d9046269f1654ec 3.6

Sorry, @william-gr and @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 28658485a54ad5f9df52ecc12d9046269f1654ec 3.7

@william-gr: it seems like the the bot failed to backport the fix. Would you mind to try to create 3.6 and 3.7 backport pull requests?

william-gr added a commit to william-gr/cpython that referenced this pull request

Sep 8, 2018

…rnam() (pythonGH-9098)

Pass the user/group name as Unicode to the formatting function, instead of always decoding a bytes string from UTF-8.. (cherry picked from commit 2865848)

Co-authored-by: William Grzybowski wg@FreeBSD.org

william-gr added a commit to william-gr/cpython that referenced this pull request

Sep 8, 2018

…rnam() (pythonGH-9098)

Pass the user/group name as Unicode to the formatting function, instead of always decoding a bytes string from UTF-8.. (cherry picked from commit 2865848)

Co-authored-by: William Grzybowski wg@FreeBSD.org

vstinner pushed a commit that referenced this pull request

Sep 9, 2018

…rnam() (GH-9098) (GH-9105)

Pass the user/group name as Unicode to the formatting function, instead of always decoding a bytes string from UTF-8.. (cherry picked from commit 2865848)

Co-authored-by: William Grzybowski wg@FreeBSD.org

vstinner pushed a commit that referenced this pull request

Sep 9, 2018

…rnam() (GH-9098) (GH-9104)

Pass the user/group name as Unicode to the formatting function, instead of always decoding a bytes string from UTF-8.. (cherry picked from commit 2865848)

Co-authored-by: William Grzybowski wg@FreeBSD.org