bpo-32174: Let .chm document display non-ASCII characters properly · Pull Request #9758 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ghost

@wjssz

Escape the body part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.

@wjssz

@miss-islington

Thanks @animalize for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 8, 2018

@miss-islington

…ythonGH-9758)

Let .chm document display non-ASCII characters properly

Escape the body part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems. (cherry picked from commit 6261ae9)

Co-authored-by: animalize animalize@users.noreply.github.com

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 8, 2018

@miss-islington

…ythonGH-9758)

Let .chm document display non-ASCII characters properly

Escape the body part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems. (cherry picked from commit 6261ae9)

Co-authored-by: animalize animalize@users.noreply.github.com

@bedevere-bot

miss-islington added a commit that referenced this pull request

Oct 8, 2018

@miss-islington

…H-9758)

Let .chm document display non-ASCII characters properly

Escape the body part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems. (cherry picked from commit 6261ae9)

Co-authored-by: animalize animalize@users.noreply.github.com

miss-islington added a commit that referenced this pull request

Oct 8, 2018

@miss-islington

…H-9758)

Let .chm document display non-ASCII characters properly

Escape the body part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems. (cherry picked from commit 6261ae9)

Co-authored-by: animalize animalize@users.noreply.github.com

@ghost ghost deleted the issue32174 branch

October 10, 2018 14:57

@mcepl

@zooba , @vstinner Is it a good idea to build .chm files even on Mac OS X/Linux, where they don't have much any use? (Not mentioning, it adds dependence on escape4chm plugin on all platforms).