bpo-34783: Fix test_nonexisting_script() by vstinner · Pull Request #9896 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

Fix test_cmd_line_script.test_nonexisting_script(): the test must not
rely on sys.executable, since main.c uses config->program which can
be different than sys.executable in many cases (for example, on macOS
when using the framework).

https://bugs.python.org/issue34783

@vstinner

Fix test_cmd_line_script.test_nonexisting_script(): the test must not rely on sys.executable, since main.c uses config->program which can be different than sys.executable in many cases (for example, on macOS when using the framework).

@vstinner

@ned-deily: When you have time, would you mind to confirm that the test now pass on macOS with framework?

ned-deily

@miss-islington

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_nonexisting_script branch

October 15, 2018 21:50

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 15, 2018

@vstinner @miss-islington

Fix test_cmd_line_script.test_nonexisting_script(): the test must not rely on sys.executable, since main.c uses config->program which can be different than sys.executable in many cases (for example, on macOS when using the framework). (cherry picked from commit ea75187)

Co-authored-by: Victor Stinner vstinner@redhat.com

@bedevere-bot

miss-islington added a commit that referenced this pull request

Oct 15, 2018

@miss-islington @vstinner

Fix test_cmd_line_script.test_nonexisting_script(): the test must not rely on sys.executable, since main.c uses config->program which can be different than sys.executable in many cases (for example, on macOS when using the framework). (cherry picked from commit ea75187)

Co-authored-by: Victor Stinner vstinner@redhat.com

vstinner added a commit that referenced this pull request

Oct 16, 2018

@vstinner

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Oct 18, 2018

@CuriousLearner

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Oct 18, 2018

@CuriousLearner