Test results are not saved anywhere. by iselind · Pull Request #88 · python/devguide (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

iselind

Clarifying that the test results are not saved anywhere.

@iselind

Clarifying that the test results are not saved anywhere.

@the-knights-who-say-ni

Hello, and thanks for your contribution!

Unfortunately our records indicate you have not signed a PSF contributor agreement (CLA). For legal reasons we need you to sign this before we can look at your contribution.

Once you have done everything that's needed, please reply here and someone will verify everything is in order.

@iselind

@iselind

@berkerpeksag

Thanks for the PR, but -1 from me. We can't and shouldn't add every small detail to the devguide. The all supported features of the test runner can already be seen by using the -h option and there is no need to document every unsupported feature.

@zhangyangyu

Agree with Berker. I don't understand why you emphasize the output. And it's obvious that you can redirect the output to store it.

@iselind

@iselind

Other new developers might be helped by this as well. Patrik Den 24 dec 2016 16:41 skrev "mrx" patrik.mrx@gmail.com:

…

@iselind

@berkerpeksag , i'm not saying everything should be repeated. Just this one.

@ammaraskar

It's still a fairly weird thing to mention since most, if not all unit testing programs I've encountered simply print out their results to stdout and set the appropriate error code when they return. I guess it helps if you've never encountered unit testing in other projects before.

Some examples:

@brettcannon

Thanks for the PR, @iselind , but the consensus is that this isn't necessary, so I'm closing this.

@iselind

I don't know if it's just me but i think that dev docs should cover enough so that as many as possible can start to help out and not assume a certain level of experience with this or that. Patrik Iselind

…

On Sat, Dec 24, 2016 at 6:35 PM, Ammar Askar ***@***.***> wrote: It's still a fairly weird thing to mention since most, if not all unit testing programs I've encountered simply print out their results to stdout and set the appropriate error code when they return. I guess it helps if you've never encountered unit testing in other projects before. Some examples: - tox - unittest module - rake (for ruby) - mocha (for js) - CUnit — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUIB0QqimglYlGt1EcaFTpfxay7z74IMks5rLVfcgaJpZM4LVNHV> .

@brettcannon

We're not trying to make Python contribution work for any person in the world who may want to help out (e.g. we are not here to teach people how to program). There is a certain level of prior knowledge necessary and we are saying that being able to read the documentation of test to know it doesn't save test results or to simply realize it doesn't like nearly all other test runners is a prerequisite to helping out with code.