Add --strict-bytes flag by hamdanal · Pull Request #18263 · python/mypy (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits2 Checks19 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This comment has been minimized.
Could you (perhaps temporarily) enable this flag during primer runs? To quickly change that, there's --additional-flags param given to mypy_primer in .github/workflows/mypy_primer.yml. It'd be interesting to see the impact of this option on the open-source corpus.
Could you (perhaps temporarily) enable this flag during primer runs? To quickly change that, there's
--additional-flagsparam given tomypy_primerin.github/workflows/mypy_primer.yml. It'd be interesting to see the impact of this option on the open-source corpus.
See the primer hits here #12661
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good, just one comment about documentation.
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅
This was referenced
Dec 10, 2024
asvetlov pushed a commit to aio-libs/aiohttp that referenced this pull request
What do these changes do?
Mypy will add a --strict-bytes flag.
python/mypy#18263
With that bytearray and memoryview are no longer subclasses of
bytes and must be listed explicitly instead if they are supported.
Are there changes in behavior for the user?
--
Related issue number
--
Checklist
- I think the code is well written
- Unit tests for the changes exist
- Documentation reflects the changes
- If you provide code modification, please add yourself to
CONTRIBUTORS.txt- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- Add a new news fragment into the
CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request number after creating the PR
.bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations..feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breaking changes in behavior..breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release..doc: Notable updates to the documentation structure or build process..packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions..contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment..misc: Changes that are hard to assign to any of the above categories.
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
Co-authored-by: J. Nick Koston nick@koston.org
patchback bot pushed a commit to aio-libs/aiohttp that referenced this pull request
What do these changes do?
Mypy will add a --strict-bytes flag.
python/mypy#18263
With that bytearray and memoryview are no longer subclasses of
bytes and must be listed explicitly instead if they are supported.
Are there changes in behavior for the user?
--
Related issue number
--
Checklist
- I think the code is well written
- Unit tests for the changes exist
- Documentation reflects the changes
- If you provide code modification, please add yourself to
CONTRIBUTORS.txt- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- Add a new news fragment into the
CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request number after creating the PR
.bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations..feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breaking changes in behavior..breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release..doc: Notable updates to the documentation structure or build process..packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions..contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment..misc: Changes that are hard to assign to any of the above categories.
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
Co-authored-by: J. Nick Koston nick@koston.org (cherry picked from commit 3f07b1a)
patchback bot pushed a commit to aio-libs/aiohttp that referenced this pull request
What do these changes do?
Mypy will add a --strict-bytes flag.
python/mypy#18263
With that bytearray and memoryview are no longer subclasses of
bytes and must be listed explicitly instead if they are supported.
Are there changes in behavior for the user?
--
Related issue number
--
Checklist
- I think the code is well written
- Unit tests for the changes exist
- Documentation reflects the changes
- If you provide code modification, please add yourself to
CONTRIBUTORS.txt- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- Add a new news fragment into the
CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request number after creating the PR
.bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations..feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breaking changes in behavior..breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release..doc: Notable updates to the documentation structure or build process..packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions..contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment..misc: Changes that are hard to assign to any of the above categories.
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
Co-authored-by: J. Nick Koston nick@koston.org (cherry picked from commit 3f07b1a)
asvetlov pushed a commit to aio-libs/aiohttp that referenced this pull request
…ation for strict-bytes (#10157)
This is a backport of PR #10154 as merged into master (3f07b1a).
What do these changes do?
Mypy will add a --strict-bytes flag.
python/mypy#18263
With that bytearray and memoryview are no longer subclasses of
bytes and must be listed explicitly instead if they are supported.
Are there changes in behavior for the user?
--
Related issue number
--
Checklist
- I think the code is well written
- Unit tests for the changes exist
- Documentation reflects the changes
- If you provide code modification, please add yourself to
CONTRIBUTORS.txt- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- Add a new news fragment into the
CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request number after creating the PR
.bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations..feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breaking changes in behavior..breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release..doc: Notable updates to the documentation structure or build process..packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions..contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment..misc: Changes that are hard to assign to any of the above categories.
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
Co-authored-by: Marc Mueller 30130371+cdce8p@users.noreply.github.com
asvetlov pushed a commit to aio-libs/aiohttp that referenced this pull request
…ation for strict-bytes (#10158)
This is a backport of PR #10154 as merged into master (3f07b1a).
What do these changes do?
Mypy will add a --strict-bytes flag.
python/mypy#18263
With that bytearray and memoryview are no longer subclasses of
bytes and must be listed explicitly instead if they are supported.
Are there changes in behavior for the user?
--
Related issue number
--
Checklist
- I think the code is well written
- Unit tests for the changes exist
- Documentation reflects the changes
- If you provide code modification, please add yourself to
CONTRIBUTORS.txt- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
- Add a new news fragment into the
CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request number after creating the PR
.bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations..feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breaking changes in behavior..breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release..doc: Notable updates to the documentation structure or build process..packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions..contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment..misc: Changes that are hard to assign to any of the above categories.
Make sure to use full sentences with correct case and punctuation, for example:
Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`.Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.
Co-authored-by: Marc Mueller 30130371+cdce8p@users.noreply.github.com