PEP 484: Remove statement about unicode, in the python2.7 section. by matthiaskramm · Pull Request #302 · python/peps (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
See python/typing#418 (comment).
Let's leave it up to type-checkers whether they want unicode, in Python 2 code, to mean "only unicode" or "str or unicode".
See python/typing#418 (comment).
Let's leave it up to type-checkers whether they want unicode, in Python 2
code, to mean "only unicode" or "str or unicode".
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
@matthiaskramm You haven't added your GitHub username to your bugs.python.org account yet.
Hang on, looks like I got an error email back from that
An unexpected error occurred during the processing
of your message. The tracker administrator is being
notified.
I'll try again, if needed with a different username.
Added my GitHub username to bugs.python.org.
Found the account, but now you have a new bugs.python.org account which has not signed the CLA. Can you sign it again quickly with the new bugs.python.org account you just created?
And now the CLA bot is happy. 😉
Yay! :) Thanks for digging through the user database for me.
@matthiaskramm quite welcome! Just glad we eventually got it resolved.
I've asked @gvanrossum to review this to make sure the wording change is okay.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not likely to change this in mypy, but this compromise sounds good to me.
| ``long`` types as equivalent. For parameters typed as ``unicode`` or |
|---|
| ``Text``, arguments of type ``str`` should be acceptable. |
| ``long`` types as equivalent. For parameters typed as ``Text``, arguments of |
| both ``str`` and ``unicode`` should be acceptable. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the word "types" somewhere. Maybe change "both" into "types"?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted the wording.
gvanrossum pushed a commit to python/typeshed that referenced this pull request
This documents, among others, the unicode -> Union[bytes, unicode] promotion that python/peps#302 removes from PEP 484.