feat: Refactor FX APIs under dynamo namespace for parity with TS APIs by peri044 · Pull Request #1807 · pytorch/TensorRT (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation61 Commits48 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project (You can use the linters)
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas and hacks
• I have made corresponding changes to the documentation
• I have added tests to verify my fix or my feature
• New and existing unit tests pass locally with my changes
• I have added the relevant labels to my PR in so that relevant reviewers are notified

• Add backend adapted from previous fx2trt_compiler provided by Dynamo
• Currently, the TRTSplitter needs work to fully support the aten path
• Additionally, the existing aten pass was reworked to exclude the torch._dynamo.export call, which may be necessary here

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

…dynamo namespace

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

This comment was marked as resolved.

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

This comment was marked as resolved.

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 only copy over the files you made changes to to the new directory. You can just import the rest from .fx

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

This comment was marked as resolved.

• Update implementation to use Dynamo partition functionality
• Update implementation to use Dynamo decompositions to replace inplace operators
• Name backends using standard names
• Add documentation, print statements, and helper functions to the code

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

This comment was marked as resolved.

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive is there anything blocking this merge?
When merged can you cherry pick into 1.4?

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

[](/apps/github-actions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

gs-olive added a commit that referenced this pull request

May 3, 2023

…#1807)

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com Co-authored-by: gs-olive 113141689+gs-olive@users.noreply.github.com

gs-olive added a commit that referenced this pull request

May 4, 2023

…#1807)

Signed-off-by: Dheeraj Peri peri.dheeraj@gmail.com Co-authored-by: gs-olive 113141689+gs-olive@users.noreply.github.com

Labels