Rollup merge of #130087 - RalfJung:option-const-iter, r=workingjubilee · qinheping/verify-rust-std@2ee8304 (original) (raw)
Navigation Menu
- GitHub Copilot Write better code with AI
- GitHub Models New Manage and compare prompts
- GitHub Advanced Security Find and fix vulnerabilities
- Actions Automate any workflow
- Codespaces Instant dev environments
- Issues Plan and track work
- Code Review Manage code changes
- Discussions Collaborate outside of code
- Code Search Find more, search less
- Explore
- Pricing
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Commit 2ee8304
Rollup merge of rust-lang#130087 - RalfJung:option-const-iter, r=workingjubilee
remove 'const' from 'Option::iter' This is kind of pointless to be a `const fn` since you can't do anything with the iterator. It is also the only `const fn iter*` in the entire standard library. It probably got constified when `~const` traits got added everywhere, and then was forgotten to be de-constified when that was undone. The rest of the const_option feature seems like it can reasonably be stabilized, but this one IMO should not be stabilized, and it's not worth creating a new tracking issue. Cc rust-lang#67441
File tree
1 file changed
lines changed
1 file changed
lines changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1338,9 +1338,8 @@ impl Option { | ||
| 1338 | 1338 | /// assert_eq!(x.iter().next(), None); |
| 1339 | 1339 | /// ``` |
| 1340 | 1340 | #[inline] |
| 1341 | -#[rustc_const_unstable(feature = "const_option", issue = "67441")] | |
| 1342 | 1341 | #[stable(feature = "rust1", since = "1.0.0")] |
| 1343 | -pub const fn iter(&self) -> Iter<'_, T> { | |
| 1342 | +pub fn iter(&self) -> Iter<'_, T> { | |
| 1344 | 1343 | Iter { inner: Item { opt: self.as_ref() } } |
| 1345 | 1344 | } |
| 1346 | 1345 |