Allow clients to report name and version by uglide · Pull Request #11758 · redis/redis (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@uglide

@uglide

hpatro

@oranagra

@oranagra

sundb

@oranagra

yangbodong22011

@oranagra

yangbodong22011

madolson

oranagra

@oranagra

madolson

madolson

@oranagra @madolson

Co-authored-by: Madelyn Olson 34459052+madolson@users.noreply.github.com

enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request

Mar 22, 2023

@enjoy-binbin

The sanity check test intention was to detect that when a command is added to sentinel it is on purpose. This test is easily broken, like CLIENT SETINFO introduced by redis#11758.

We replace it with a test that validates that a few specific commands are either there or missing (to test the infrastructure works correctly).

oranagra pushed a commit that referenced this pull request

Mar 22, 2023

@enjoy-binbin

…11950)

The sanity check test intention was to detect that when a command is added to sentinel it is on purpose. This test is easily broken, like CLIENT SETINFO introduced by #11758.

We replace it with a test that validates that a few specific commands are either there or missing (to test the infrastructure works correctly).

@tezc tezc mentioned this pull request

Mar 23, 2023

oranagra pushed a commit that referenced this pull request

Mar 23, 2023

@tezc

Added missing needs:reset tag.

Introduced by #11758

This was referenced

Mar 27, 2023

NickCraver added a commit to StackExchange/StackExchange.Redis that referenced this pull request

Mar 28, 2023

@mgravell @NickCraver

Includes:

note we can't validate this yet as not on any released servers

most contentious point: what lib-name to use - I've gone with SE.Redis, but: happy to use StackExchange.Redis if people prefer; I'm not aiming to make the name configurable

cross-reference: redis/redis#11758

Co-authored-by: Nick Craver nrcraver@gmail.com