fix(args): make header argument optional by orhun · Pull Request #2678 · rust-lang/rust-bindgen (original) (raw)
I think this is OK as a workaround but we should try to do this using clap sometime in the future.
aimixsaka added a commit to aimixsaka/archriscv-packages that referenced this pull request
- Fix rotten
- Upstream and Arch x86_64 released v0.69.1, which contains already merged patch: rust-lang/rust-bindgen#2678, so no need for it. (Successfully built without this patch)
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request
- Fix rotten
- Upstream and Arch x86_64 released v0.69.1, which contains already merged patch: rust-lang/rust-bindgen#2678, so no need for it. (Successfully built without this patch)
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions.
In order to help achieve that goal, the Rust project has added the kernel
to its Rust pre-merge CI. This commit does the same for bindgen.
In particular, it adds a quick, build-only test of the Rust code in
the kernel done as an added, last step in the test workflow. As it is
implemented, it adds about 1-2 minutes of CI time.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2567 [1] Link: rust-lang#2678 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2567 [1] Link: rust-lang#2678 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2567 [1] Link: rust-lang#2678 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2567 [1] Link: rust-lang#2678 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2678 [1] Link: rust-lang#2567 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2678 [1] Link: rust-lang#2567 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2678 [1] Link: rust-lang#2567 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/rust-bindgen that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: rust-lang#2678 [1] Link: rust-lang#2567 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org
fbq pushed a commit to Rust-for-Linux/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org Link: https://lore.kernel.org/r/20240701183625.665574-9-ojeda@kernel.org
Darksonn pushed a commit to Darksonn/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org Tested-by: Benno Lossin benno.lossin@proton.me
fbq pushed a commit to Rust-for-Linux/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Signed-off-by: Miguel Ojeda ojeda@kernel.org Link: https://lore.kernel.org/r/20240701183625.665574-9-ojeda@kernel.org
ojeda added a commit to ojeda/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Signed-off-by: Miguel Ojeda ojeda@kernel.org
fbq pushed a commit to Rust-for-Linux/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Signed-off-by: Miguel Ojeda ojeda@kernel.org Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
mj22226 pushed a commit to mj22226/linux that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
mj22226 pushed a commit to mj22226/linux that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
johnny-mnemonic pushed a commit to linux-ia64/linux-stable-rc that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
gregkh pushed a commit to gregkh/linux that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
gregkh pushed a commit to gregkh/linux that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
gregkh pushed a commit to gregkh/linux that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
Avenger-285714 pushed a commit to Avenger-285714/DeepinKernel that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
Avenger-285714 pushed a commit to deepin-community/kernel that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
github-merge-queue bot pushed a commit that referenced this pull request
Rust for Linux, so far, has pinned the Rust compiler and bindgen
versions. The kernel is looking into expanding that support to several
versions, i.e. establishing a minimum supported version, so that the
kernel can start to be more easily built. In particular, it should be
possible to build the kernel using the tools provided directly by Linux
distributions. In order to help achieve that goal, the Rust project has
added the kernel to its Rust pre-merge CI.
This commit does the same for bindgen. In particular, it adds a quick,
build-only test of the Rust code in the kernel as an extra step in the
test workflow.
This is intended to be an end-to-end test that runs what kernel
developers/users would do. In particular, it is useful to catch certain
issues that go beyond the C header comparisons. For instance, it would
have been able to catch an issue like the --version option unexpectedly
requiring a header in 0.69.0 (fixed in 0.69.1) [1].
It would also have detected another issue present in 0.66.0 and 0.66.1: a panic handling certain C headers with string literals containing an interior NUL [2]. While the kernel is not really a stable test, and such an issue would still require that a proper test is added, it is nevertheless a good test case of non-trivial C headers that may trigger edge cases like that.
Of course, bindgen may need to disable the test for different reasons,
i.e. there is no expectation to block any urgent/important PR, and the
kernel can also call bindgen differently depending on the version,
i.e. we are happy to adjust on our side too. Even if it gets disabled
often, we would still be in a better situation than not having the test
at all.
The Linux version (hash or tag) should ideally be updated from time to
time (e.g. every kernel -rc1), and each update should only contain
that change.
Link: #2678 [1] Link: #2567 [2] Signed-off-by: Miguel Ojeda ojeda@kernel.org
wanghao75 pushed a commit to openeuler-mirror/kernel that referenced this pull request
stable inclusion from stable-v6.6.48 commit 34e1335905f2311a3d788108ae0a5102719f068d category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IAWEBV
[ Upstream commit 9e98db17837093cb0f4dcfcc3524739d93249c45 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6c8613 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org Signed-off-by: Wen Zhiwei wenzhiwei@kylinos.cn
rene pushed a commit to rene/eve-kernel that referenced this pull request
[ Upstream commit 9e98db1 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org
33 tasks
miax-gevu pushed a commit to gevulotnetwork/kernel-optimized that referenced this pull request
BugLink: https://bugs.launchpad.net/bugs/2084005
[ Upstream commit 9e98db17837093cb0f4dcfcc3524739d93249c45 ]
bindgen 0.69.0 contains a bug: --version does not work without
providing a header [1]:
error: the following required arguments were not provided:
<HEADER>
Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...Thus, in preparation for supporting several bindgen versions, work
around the issue by passing a dummy argument.
Include a comment so that we can remove the workaround in the future.
Link: rust-lang/rust-bindgen#2678 [1] Reviewed-by: Finn Behrens me@kloenk.dev Tested-by: Benno Lossin benno.lossin@proton.me Tested-by: Andreas Hindborg a.hindborg@samsung.com Link: https://lore.kernel.org/r/20240709160615.998336-9-ojeda@kernel.org Signed-off-by: Miguel Ojeda ojeda@kernel.org Stable-dep-of: 5ce86c6c8613 ("rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT") Signed-off-by: Sasha Levin sashal@kernel.org Signed-off-by: Koichiro Den koichiro.den@canonical.com Signed-off-by: Stefan Bader stefan.bader@canonical.com