New lint (unnecessary_safety_comment): reverse of undocumented_unsafe_blocks · Issue #7954 · rust-lang/rust-clippy (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

What it does

Warns about unexpected // SAFETY: comments (i.e. the reverse of the undocumented_unsafe_blocks lint).

This lint is similar to #6880, which is requesting the reverse of missing_safety_docs.

Drawbacks

• A project might also be using // SAFETY: comments to explain why safe code makes other unsafe code sound, e.g. within the module.
• Potential false positives in general (depending on how it is implemented).

Example

// SAFETY: x is Some. x.unwrap()

Could be written as: