compiletest::runtest: aggressive_rm_rf does not like symlinks on Windows · Issue #129155 · rust-lang/rust (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

While reviewing #128562 and testing I discovered that runtest.rs's aggressive_rm_rf is not aggressive enough, unfortunately, because symlink-to-dir and symlink-to-file on Windows need different handling.

Have not considered junction points and hard links.

This can cause a rmake.rs test that creates symlinks to have its output artifacts fail to be removed on non-fresh test runs.