legacy_imports future-compatibility warnings · Issue #38260 · rust-lang/rust (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

This is the summary issue for the legacy_imports future-compatibility warning and other related errors. The goal of this page is describe why this change was made and how you can fix code that is affected by it. It also provides a place to ask questions or register a complaint if you feel the change should not be made.

What is the warning for?

The legacy_imports warning is issued when

• a glob import of an ancestor module (e.g. use super::*) imports a non-pub name,
• the name is also imported by another glob import, making it ambiguous, and
• the name is used, triggering an ambiguity error.

See RFC 1560 for more detailed information.

When will this warning become a hard error?

At the beginning of each 6-week release cycle, the Rust compiler team will review the set of outstanding future compatibility warnings and nominate some of them for Final Comment Period. Toward the end of the cycle, we will review any comments and make a final determination whether to convert the warning into a hard error or remove it entirely.

Current status

• resolve: change most backwards incompatible ambiguity errors to legacy_imports warnings #38271 introduces the legacy_imports lint as warn-by-default
• Make sufficiently old or low-impact compatibility lints deny-by-default #42894 makes the legacy_imports lint deny-by-default
• PR ? makes the legacy_imports lint a hard error