Bad suggestion dyn pub on proc macro (#61963 regressed) · Issue #74043 · rust-lang/rust (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

#72306 causes the compiler to emit (and blessed) this bad suggestion in the test for #61963 (output):

error: trait objects without an explicit `dyn` are deprecated
  --> $DIR/issue-61963.rs🔞1
   |
LL | pub struct Foo {
   | ^^^ help: use `dyn`: `dyn pub`

This is the behaviour the test is supposed to guard against (almost - the original bad suggestion was to insert dyn before the proc macro attribute), so the issue is regressed.

The issue was originally fixed nearly a year ago, so this is a regression from stable.