introduce {char, u8}::is_ascii_octdigit by oppiliappan · Pull Request #101308 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This feature adds two new APIs: char::is_ascii_octdigit and u8::is_ascii_octdigit, under the feature gate is_ascii_octdigit. These methods are shorthands for char::is_digit(self, 8) and u8::is_digit(self, 8):

// core::char

impl char { pub fn is_ascii_octdigit(self) -> bool; }

// core::num

impl u8 { pub fn is_ascii_octdigit(self) -> bool; }

Couple of things I need help understanding:

• constness: have I used the right attribute in this case?
• is there a way to run the tests for core::char alone, instead of ./x.py test library/core?

rustbot added the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Sep 2, 2022

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

oppiliappan changed the titleintroduce {char, u8}::is_ascii_octdigit introduce {char, u8}::is_ascii_octdigit

Sep 2, 2022

I'm going to flip this over to libs-api for their review of things.

Taking the other person from the last time I did a coin flip for this,
r? @joshtriplett

Looks great to me. And the unstable markers look correct as well.

r=me with the merge conflict fixed and the doc(hidden) removed.

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

📌 Commit 591c1f2 has been approved by joshtriplett

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 3, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 3, 2022

…git, r=joshtriplett

introduce {char, u8}::is_ascii_octdigit

This feature adds two new APIs: char::is_ascii_octdigit and u8::is_ascii_octdigit, under the feature gate is_ascii_octdigit. These methods are shorthands for char::is_digit(self, 8) and u8::is_digit(self, 8):

// core::char

impl char {
    pub fn is_ascii_octdigit(self) -> bool;
}

// core::num

impl u8 {
    pub fn is_ascii_octdigit(self) -> bool;
}

Couple of things I need help understanding:

• constness: have I used the right attribute in this case?
• is there a way to run the tests for core::char alone, instead of ./x.py test library/core?

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 3, 2022

…git, r=joshtriplett

introduce {char, u8}::is_ascii_octdigit

This feature adds two new APIs: char::is_ascii_octdigit and u8::is_ascii_octdigit, under the feature gate is_ascii_octdigit. These methods are shorthands for char::is_digit(self, 8) and u8::is_digit(self, 8):

// core::char

impl char {
    pub fn is_ascii_octdigit(self) -> bool;
}

// core::num

impl u8 {
    pub fn is_ascii_octdigit(self) -> bool;
}

Couple of things I need help understanding:

• constness: have I used the right attribute in this case?
• is there a way to run the tests for core::char alone, instead of ./x.py test library/core?

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 3, 2022

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#98218 (Document the conditional existence of alloc::sync and alloc::task.)
• rust-lang#99216 (docs: be less harsh in wording for Vec::from_raw_parts)
• rust-lang#99460 (docs: Improve AsRef / AsMut docs on blanket impls)
• rust-lang#100470 (Tweak FpCategory example order.)
• rust-lang#101040 (Fix #[derive(Default)] on a generic #[default] enum adding unnecessary Default bounds)
• rust-lang#101308 (introduce {char, u8}::is_ascii_octdigit)
• rust-lang#102486 (Add diagnostic struct for const eval error in rustc_middle)

Failed merges:

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.