Add ptr::Alignment type by scottmcm · Pull Request #102072 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Essentially no new code here, just exposing the previously-pub(crate) ValidAlign type under the name from the ACP.

rustbot added the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Sep 20, 2022

This comment has been minimized.

scottmcm marked this pull request as ready for review

September 21, 2022 22:06

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

rustbot added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

Sep 21, 2022

Flipping to a non-api reviewer to help free up Mara, since the ACP is seconded
r? @thomcc

Looks great to me. I think it could use stuff like From<Alignment> for usize/NonZeroUsize, but as you mentioned in the ACP, this stuff is not needed from the start.

@bors r+

📌 Commit c158b7b has been approved by thomcc

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 8, 2022

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request

Oct 9, 2022

Add ptr::Alignment type

Essentially no new code here, just exposing the previously-pub(crate) ValidAlign type under the name from the ACP.

ACP: rust-lang/libs-team#108 Tracking Issue: rust-lang#102070

r? @ghost

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 9, 2022

Rollup of 8 pull requests

Successful merges:

• rust-lang#101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD)
• rust-lang#102072 (Add ptr::Alignment type)
• rust-lang#102799 (rustdoc: remove hover gap in file picker)
• rust-lang#102820 (Show let-else suggestion on stable.)
• rust-lang#102829 (rename ImplItemKind::TyAlias to ImplItemKind::Type)
• rust-lang#102831 (Don't use unnormalized type in Ty::fn_sig call in rustdoc clean_middle_ty)
• rust-lang#102834 (Remove unnecessary lift/lift_to_tcx calls from rustdoc)
• rust-lang#102838 (remove cfg(bootstrap) from Miri)

Failed merges:

r? @ghost @rustbot modify labels: rollup

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Oct 10, 2022

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Oct 10, 2022

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Nov 12, 2022

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Nov 12, 2022

Manishearth added a commit to Manishearth/rust that referenced this pull request

Nov 18, 2022

Constify remaining Layout methods

Makes the methods on Layout that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying ValidAlignment which may affect rust-lang#102072

Manishearth added a commit to Manishearth/rust that referenced this pull request

Nov 18, 2022

Constify remaining Layout methods

Makes the methods on Layout that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying ValidAlignment which may affect rust-lang#102072

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request

Nov 19, 2022

Constify remaining Layout methods

Makes the methods on Layout that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying ValidAlignment which may affect rust-lang#102072

Manishearth added a commit to Manishearth/rust that referenced this pull request

Nov 22, 2022

Constify remaining Layout methods

Makes the methods on Layout that aren't yet unstably const, under the same feature and issue, rust-lang#67521. Most of them required no changes, only non-trivial change is probably constifying ValidAlignment which may affect rust-lang#102072

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request

Jan 6, 2023

Rollup of 8 pull requests

Successful merges:

• rust-lang#101118 (fs::get_mode enable getting the data via fcntl/F_GETFL on major BSD)
• rust-lang#102072 (Add ptr::Alignment type)
• rust-lang#102799 (rustdoc: remove hover gap in file picker)
• rust-lang#102820 (Show let-else suggestion on stable.)
• rust-lang#102829 (rename ImplItemKind::TyAlias to ImplItemKind::Type)
• rust-lang#102831 (Don't use unnormalized type in Ty::fn_sig call in rustdoc clean_middle_ty)
• rust-lang#102834 (Remove unnecessary lift/lift_to_tcx calls from rustdoc)
• rust-lang#102838 (remove cfg(bootstrap) from Miri)

Failed merges:

r? @ghost @rustbot modify labels: rollup

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request

Feb 10, 2023

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.