Stabilize `::{core,std}::pin::pin!` by danielhenrymantilla · Pull Request #103800 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

As discussed over here, it looks like a decent time to stabilize the pin! macro.

Public API

// in module core::pin

/// API: fn pin<T>($value: T) -> Pin<&'local mut T> pub macro pin($value:expr $(,)?) { … }

Tracking issue: Tracking Issue for core::pin::pin! #93178

(now all this needs is an FCP by the proper team?)

taiki-e, yoshuawuyts, vincenzopalazzo, Noratrieb, ilslv, slanterns, Kobzol, andreytkachenko, ibraheemdev, rrbutani, and 20 more reacted with hooray emoji

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Oct 31, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

The Miri subtree was changed

cc @rust-lang/miri

rustbot added T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

A-async-await

Area: Async & Await

and removed T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Oct 31, 2022

Since this needs an FCP, which I can't do,
r? rust-lang/libs-api

scottmcm added the needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

label

Nov 9, 2022

cc/ @rust-lang/libs-api, @rust-lang/wg-async

@rustbot modify labels: -S-waiting-on-review +S-waiting-on-team

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this feature got proposed for FCP.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-team

Status: Awaiting decision from the relevant subteam (see the T- label).

labels

Jan 7, 2023

JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request

Jan 8, 2023

…macro, r=dtolnay

Stabilize ::{core,std}::pin::pin!

As discussed [over here](rust-lang#93178 (comment)), it looks like a decent time to stabilize the pin! macro.

Public API

// in module `core::pin`

/// API: `fn pin<T>($value: T) -> Pin<&'local mut T>`
pub macro pin($value:expr $(,)?) {
    …
}

Tracking issue: rust-lang#93178

(now all this needs is an FCP by the proper team?)

@bors r-
This needs a rebase to remove more feature gates.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jan 8, 2023

📌 Commit 980d09b7350efc7e56e22ad6a05f2af6c68a93be has been approved by dtolnay

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 10, 2023

📌 Commit 48b7e2a has been approved by dtolnay

It is now in the queue for this repository.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request

Jan 12, 2023

…macro, r=dtolnay

Stabilize ::{core,std}::pin::pin!

As discussed [over here](rust-lang#93178 (comment)), it looks like a decent time to stabilize the pin! macro.

Public API

// in module `core::pin`

/// API: `fn pin<T>($value: T) -> Pin<&'local mut T>`
pub macro pin($value:expr $(,)?) {
    …
}

Tracking issue: rust-lang#93178

(now all this needs is an FCP by the proper team?)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 12, 2023

…mpiler-errors

Rollup of 8 pull requests

Successful merges:

rust-lang#103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub})
rust-lang#103800 (Stabilize ::{core,std}::pin::pin!)
rust-lang#106097 (Migrate mir_build diagnostics 2 of 3)
rust-lang#106170 (Move autoderef to rustc_hir_analysis)
rust-lang#106323 (Stabilize f16c_target_feature)
rust-lang#106360 (Tweak E0277 &-removal suggestions)
rust-lang#106524 (Label struct/enum constructor instead of fn item, mention that it should be called on type mismatch)
rust-lang#106739 (Remove <dyn AstConv<'tcx>>::fun(c, ...) calls in favour of c.astconv().fun(...))