riscv: Fix ELF header flags by FawazTirmizi · Pull Request #106797 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The previous version added both EF_RISCV_FLOAT_ABI_DOUBLE and EF_RISCV_RVC if the "D" extension was enabled on riscv64 targets. riscv32 targets were not accounted for. This patch changes this so that:
- Only add
EF_RISCV_RVCif the "C" extension is enabled - Add
EF_RISCV_FLOAT_ABI_SINGLEif the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well
Fixes #104284
r? rust-lang/risc-v
The previous version added both EF_RISCV_FLOAT_ABI_DOUBLE and
EF_RISCV_RVC if the "D" extension was enabled on riscv64 targets.
riscv32 targets were not accounted for. This patch changes this
so that:
- Only add
EF_RISCV_RVCif the "C" extension is enabled - Add
EF_RISCV_FLOAT_ABI_SINGLEif the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well
Failed to set assignee to kraj: invalid assignee
Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kraj (or someone else) soon.
Please see the contribution instructions for more information.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
kraj approved these changes Jan 13, 2023
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📌 Commit 138a1d2 has been approved by bjorn3
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…bjorn3
riscv: Fix ELF header flags
The previous version added both EF_RISCV_FLOAT_ABI_DOUBLE and EF_RISCV_RVC if the "D" extension was enabled on riscv64 targets. riscv32 targets were not accounted for. This patch changes this so that:
- Only add
EF_RISCV_RVCif the "C" extension is enabled - Add
EF_RISCV_FLOAT_ABI_SINGLEif the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well
Fixes rust-lang#104284
r? rust-lang/risc-v
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…bjorn3
riscv: Fix ELF header flags
The previous version added both EF_RISCV_FLOAT_ABI_DOUBLE and EF_RISCV_RVC if the "D" extension was enabled on riscv64 targets. riscv32 targets were not accounted for. This patch changes this so that:
- Only add
EF_RISCV_RVCif the "C" extension is enabled - Add
EF_RISCV_FLOAT_ABI_SINGLEif the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well
Fixes rust-lang#104284
r? rust-lang/risc-v
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#104645 (Add log-backtrace option to show backtraces along with logging)
- rust-lang#106465 (Bump
IMPLIED_BOUNDS_ENTAILMENTto Deny + ReportNow) - rust-lang#106489 (Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang))
- rust-lang#106585 (When suggesting writing a fully qualified path probe for appropriate types)
- rust-lang#106641 (Provide help on closures capturing self causing borrow checker errors)
- rust-lang#106678 (Warn when using panic-strategy abort for proc-macro crates)
- rust-lang#106701 (Fix
mpsc::SyncSenderspinning behavior) - rust-lang#106793 (Normalize test output more thoroughly)
- rust-lang#106797 (riscv: Fix ELF header flags)
- rust-lang#106813 (Remove redundant session field)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.