Fix target_feature 1.1 should print the list of missing target features by rohaquinlop · Pull Request #109710 · rust-lang/rust (original) (raw)

Ohh you meant what I am asking you to do reflects the older state of a PR, and you were asked to change it? I don't think so, but please correct me if I'm wrong. The older state also had a match, just no if let inside. Now you are doing both. Ideally you'd just have an if let, like:

if let Some(note_missing_features) = self.details.violation.note_missing_features() { diag.note(note_missing_features); } else { diag.note(self.details.clone().note()); }

The note_missing_features function will already return None if it's not a CallToFunctionWith, we just use this fact here.

My demand is more or less the same thing I asked about in march: #109710 (comment)

If you need more clarifications, please ask!