Add -Ztrait-solver=next-coherence by compiler-errors · Pull Request #112122 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Flag that conditionally uses the trait solver only during coherence, for more testing and/or eventual partial-migration onto the trait solver (in the medium- to long-term).
- This still uses the selection context in some of the coherence methods I think, so it's not "complete". Putting this up for review and/or for further work in-tree.
- I probably need to spend a bit more time making sure that we don't sneakily create any other infcx's during coherence that also need the new solver enabled.
r? @lcnr
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.
cc @rust-lang/initiative-trait-system-refactor bc of a lack of auto-ping
Why do we need a bool on InferCtxt instead of deriving that information from the flag + whether intercrate mode is set
I had originally wanted to make it configurable independently of intercrate mode, but yeah, currently it doesn't need to be a separate bool.
I had originally wanted to make it configurable independently of intercrate mode, but yeah, currently it doesn't need to be a separate bool.
I think that's valuable, would also expect us to e.g. move wf check and mir typeck to the new solver separately from typeck
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vibe: can you change use_next_trait_solver to next_trait_solver? idk, use feels somewhat redundant to me and makes stuff harder to read imo
after nits r=me
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Some changes occurred to the core trait solver
cc @rust-lang/initiative-trait-system-refactor
📌 Commit aabdeed has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#112076 (Fall back to bidirectional normalizes-to if no subst-relate candidate in alias-relate goal)
- rust-lang#112122 (Add
-Ztrait-solver=next-coherence) - rust-lang#112251 (rustdoc: convert
if let Some()that always matches to variable) - rust-lang#112345 (fix(expand): prevent infinity loop in macro containing only "///")
- rust-lang#112359 (Respect
RUST_BACKTRACEfor delayed bugs) - rust-lang#112382 (download-rustc: Fix
x test coreon MacOS)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)