Recover dyn and impl after for<...> by compiler-errors · Pull Request #117891 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Recover dyn and impl after for<...> in types. Reuses the logic for parsing bare trait objects, so it doesn't fix cases like for<'a> dyn Trait + dyn Trait or anything, but that seems somewhat of a different issue.

Parsing recovery logic is a bit involved, but I couldn't find a way to simplify it.

Fixes #117882

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌 Commit a8a2ee4 has been approved by davidtwco

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 19, 2023

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Nov 20, 2023

…=davidtwco

Recover dyn and impl after for<...>

Recover dyn and impl after for<...> in types. Reuses the logic for parsing bare trait objects, so it doesn't fix cases like for<'a> dyn Trait + dyn Trait or anything, but that seems somewhat of a different issue.

Parsing recovery logic is a bit involved, but I couldn't find a way to simplify it.

Fixes rust-lang#117882

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 20, 2023

…mpiler-errors

Rollup of 8 pull requests

Successful merges:

• rust-lang#115526 (Add arm64e-apple-ios & arm64e-apple-darwin targets)
• rust-lang#115691 (Add $message_type field to distinguish json diagnostic outputs)
• rust-lang#117828 (Avoid iterating over hashmaps in astconv)
• rust-lang#117832 (interpret: simplify handling of shifts by no longer trying to handle signed and unsigned shift amounts in the same branch)
• rust-lang#117891 (Recover dyn and impl after for<...>)
• rust-lang#117957 (if available use a Child's pidfd for kill/wait)
• rust-lang#117994 (Ignore but do not assume region obligations from unifying headers in negative coherence)
• rust-lang#118068 (subtree update cg_gcc 2023/11/17)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 20, 2023

…mpiler-errors

Rollup of 8 pull requests

Successful merges:

• rust-lang#115526 (Add arm64e-apple-ios & arm64e-apple-darwin targets)
• rust-lang#115691 (Add $message_type field to distinguish json diagnostic outputs)
• rust-lang#117828 (Avoid iterating over hashmaps in astconv)
• rust-lang#117832 (interpret: simplify handling of shifts by no longer trying to handle signed and unsigned shift amounts in the same branch)
• rust-lang#117891 (Recover dyn and impl after for<...>)
• rust-lang#117957 (if available use a Child's pidfd for kill/wait)
• rust-lang#117994 (Ignore but do not assume region obligations from unifying headers in negative coherence)
• rust-lang#118068 (subtree update cg_gcc 2023/11/17)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 20, 2023

…mpiler-errors

Rollup of 8 pull requests

Successful merges:

• rust-lang#117828 (Avoid iterating over hashmaps in astconv)
• rust-lang#117832 (interpret: simplify handling of shifts by no longer trying to handle signed and unsigned shift amounts in the same branch)
• rust-lang#117891 (Recover dyn and impl after for<...>)
• rust-lang#117957 (if available use a Child's pidfd for kill/wait)
• rust-lang#117988 (Handle attempts to have multiple cfgd tail expressions)
• rust-lang#117994 (Ignore but do not assume region obligations from unifying headers in negative coherence)
• rust-lang#118000 (Make regionck care about placeholders in outlives components)
• rust-lang#118068 (subtree update cg_gcc 2023/11/17)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 20, 2023

…tthiaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#117828 (Avoid iterating over hashmaps in astconv)
• rust-lang#117832 (interpret: simplify handling of shifts by no longer trying to handle signed and unsigned shift amounts in the same branch)
• rust-lang#117891 (Recover dyn and impl after for<...>)
• rust-lang#117957 (if available use a Child's pidfd for kill/wait)
• rust-lang#117988 (Handle attempts to have multiple cfgd tail expressions)
• rust-lang#117994 (Ignore but do not assume region obligations from unifying headers in negative coherence)
• rust-lang#118000 (Make regionck care about placeholders in outlives components)
• rust-lang#118068 (subtree update cg_gcc 2023/11/17)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Nov 20, 2023

Rollup merge of rust-lang#117891 - compiler-errors:recover-for-dyn, r=davidtwco

Recover dyn and impl after for<...>

Recover dyn and impl after for<...> in types. Reuses the logic for parsing bare trait objects, so it doesn't fix cases like for<'a> dyn Trait + dyn Trait or anything, but that seems somewhat of a different issue.

Parsing recovery logic is a bit involved, but I couldn't find a way to simplify it.

Fixes rust-lang#117882

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.