bootstrap(builder.rs): Don't explicitly warn against semicolon_in_expressions_from_macros by Xanewok · Pull Request #118642 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See #79813 for the tracking issue.
…pressions_from_macros`
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See rust-lang#79813 for the tracking issue.
r? @clubby789
(rustbot has picked a reviewer for you, use r? to override)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
📌 Commit a0ba895 has been approved by clubby789
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bootstrap(builder.rs): Don't explicitly warn against semicolon_in_expressions_from_macros
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See rust-lang#79813 for the tracking issue.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
bootstrap(builder.rs): Don't explicitly warn against semicolon_in_expressions_from_macros
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See rust-lang#79813 for the tracking issue.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
bootstrap(builder.rs): Don't explicitly warn against semicolon_in_expressions_from_macros
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See rust-lang#79813 for the tracking issue.
This was referenced
Dec 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#117793 (Update variable name to fix
unused_variableswarning) - rust-lang#118123 (Add support for making lib features internal)
- rust-lang#118268 (Pretty print
Fn<(..., ...)>trait refs with parentheses (almost) always) - rust-lang#118346 (Add
deeply_normalize_for_diagnostics, use it in coherence) - rust-lang#118350 (Simplify Default for tuples)
- rust-lang#118450 (Use OnceCell in cell module documentation)
- rust-lang#118585 (Fix parser ICE when recovering
dyn/implafterfor<...>) - rust-lang#118587 (Cleanup error handlers some more)
- rust-lang#118642 (bootstrap(builder.rs): Don't explicitly warn against
semicolon_in_expressions_from_macros)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#117793 (Update variable name to fix
unused_variableswarning) - rust-lang#118123 (Add support for making lib features internal)
- rust-lang#118268 (Pretty print
Fn<(..., ...)>trait refs with parentheses (almost) always) - rust-lang#118346 (Add
deeply_normalize_for_diagnostics, use it in coherence) - rust-lang#118350 (Simplify Default for tuples)
- rust-lang#118450 (Use OnceCell in cell module documentation)
- rust-lang#118585 (Fix parser ICE when recovering
dyn/implafterfor<...>) - rust-lang#118587 (Cleanup error handlers some more)
- rust-lang#118642 (bootstrap(builder.rs): Don't explicitly warn against
semicolon_in_expressions_from_macros)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#117793 (Update variable name to fix
unused_variableswarning) - rust-lang#118123 (Add support for making lib features internal)
- rust-lang#118268 (Pretty print
Fn<(..., ...)>trait refs with parentheses (almost) always) - rust-lang#118346 (Add
deeply_normalize_for_diagnostics, use it in coherence) - rust-lang#118350 (Simplify Default for tuples)
- rust-lang#118450 (Use OnceCell in cell module documentation)
- rust-lang#118585 (Fix parser ICE when recovering
dyn/implafterfor<...>) - rust-lang#118587 (Cleanup error handlers some more)
- rust-lang#118642 (bootstrap(builder.rs): Don't explicitly warn against
semicolon_in_expressions_from_macros)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#117793 (Update variable name to fix
unused_variableswarning) - rust-lang#118123 (Add support for making lib features internal)
- rust-lang#118268 (Pretty print
Fn<(..., ...)>trait refs with parentheses (almost) always) - rust-lang#118346 (Add
deeply_normalize_for_diagnostics, use it in coherence) - rust-lang#118350 (Simplify Default for tuples)
- rust-lang#118450 (Use OnceCell in cell module documentation)
- rust-lang#118585 (Fix parser ICE when recovering
dyn/implafterfor<...>) - rust-lang#118587 (Cleanup error handlers some more)
- rust-lang#118642 (bootstrap(builder.rs): Don't explicitly warn against
semicolon_in_expressions_from_macros)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#118642 - Xanewok:patch-1, r=clubby789
bootstrap(builder.rs): Don't explicitly warn against semicolon_in_expressions_from_macros
This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.
See rust-lang#79813 for the tracking issue.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
add comment about keeping flags in sync between bootstrap.py and bootstrap.rs
They got out of sync, probably because this comment was missing on the Python side (it only exists on the Rust side). rust-lang#118642 brings the flags back in sync but does not fix the comment, so let's do that here.
r? clubby789
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#118650 - RalfJung:flags-sync, r=clubby789
add comment about keeping flags in sync between bootstrap.py and bootstrap.rs
They got out of sync, probably because this comment was missing on the Python side (it only exists on the Rust side). rust-lang#118642 brings the flags back in sync but does not fix the comment, so let's do that here.
r? clubby789
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)