remove redundant imports by surechen · Pull Request #118692 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation37 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
detects redundant imports that can be eliminated.
for #117772 :
In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.
r? @TaKO8Ki
(rustbot has picked a reviewer for you, use r? to override)
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
Operating system: Unix-like
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
r=me after removing allows.
@rustbot author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
r=me after removing
allows. @rustbot author
Ok. Thank you.
Some changes occurred in src/tools/rustfmt
cc @rust-lang/rustfmt
Some changes occurred in src/librustdoc/clean/types.rs
cc @camelid
Some changes occurred in compiler/rustc_codegen_cranelift
cc @bjorn3
The Miri subtree was changed
cc @rust-lang/miri
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.
cc @rust-lang/rust-analyzer
This PR changes Stable MIR
cc @oli-obk, @celinval, @spastorino, @ouz-a
Some changes might have occurred in exhaustiveness checking
cc @Nadrieril
Marks issues that should be documented in the release notes of the next release.
label
📌 Commit 4b64fbf has been approved by petrochenkov
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This is only cleanup, actual implementation in other PR, why relnotes label?
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…petrochenkov
remove redundant imports
detects redundant imports that can be eliminated.
for rust-lang#117772 :
In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.
r? @petrochenkov
Yes, relnotes should be on #117772.
Marks issues that should be documented in the release notes of the next release.
label
This comment was marked as resolved.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Thanks, I genuinely appreciate you not only taking the time to reply, but engaging in discussion of the topic! ❤️ 🙏
You're correct that I've expressed this sentiment before, and I've also seen it echoed/shared by other subtree maintainers elsewhere. I confess I've found it confusing and occasionally frustrating when those sentiments are outright ignored or quickly dismissed.
This is probably a topic best to continue discussing in Zulip, but suffice to say that I feel the dev guide has prescribed guidance on this topic which is often contradicted in practice, and at a minimum I think that's something which should be addressed (even if that means reversing or clarifying the language in the dev guide)
Rebasing rustfmt subtree over changes like this during update is trivial,
fwiw this is incorrect, rebasing cannot be used on the subtree pushes which is a big part of why i keep raising this issue. it does produce very real challenges for us, i promise i'm not just making noise on the basis of speculation 😅
On the rust-analyzer side, I'm very worried about merging back these changes because we've had problems with git-subtree in the past, and it seems a little janky at times (it's been saying for about 6 months that it's resolving one specific conflict on every sync back). In practice, though, merging back trivial PRs like this one hasn't been an issue yet.
It does feel, however, like they're becoming more and more common lately, and it's sometimes even hard to keep with them. I understand build fixes, but doing this for cosmetic changes really feels unnecessary. Lints in particular are a bit weird -- on the RA side we're fine with the stable ones. If it's that important for rust-lang/rust to run unstable (or changed in nightly) lints against subtrees, okay, we'll handle it, but it's pretty stressful.
PS: I noticed recently that syncing back yields a ton of conflicts if the upstream (RA) has new commits. But if you do it in two steps (merge up to the version that's in downstream, then merge again with master), it's much better. Just something to keep in mind.
Well said @lnicola
For me it's not about any one particular change in isolation, it's very much the aggregate set of changes that I find often has a compounding effect on complicating the subtree syncs and the increase in frequency of such changes. git subtree is indeed very touchy and, for whatever reason, quickly and easily gets very fussy
(edit: typo correction)
detects redundant imports that can be eliminated.
for rust-lang#117772 :
In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.
📌 Commit 40ae341 has been approved by petrochenkov
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This was referenced
Dec 10, 2023
Finished benchmarking commit (84f6130): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 3.9% | [3.7%, 4.0%] | 2 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 8.4% | [5.4%, 11.3%] | 6 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 669.935s -> 668.621s (-0.20%)
Artifact size: 314.15 MiB -> 314.12 MiB (-0.01%)
celinval added a commit to celinval/rust-dev that referenced this pull request
Update Rust toolchain from nightly-2023-12-10 to nightly-2023-12-11
without any other source changes.
This is an automatically generated pull request. If any of the CI checks
fail, manual intervention is required. In such a case, review the
changes at https://github.com/rust-lang/rust from
rust-lang@06e02d5
up to
rust-lang@d86d65b.
The log for this commit range is:
rust-lang@d86d65bbc1 Auto merge of
rust-lang#118368 - GuillaumeGomez:env-flag, r=Nilstrieb
rust-lang@ec4176167b Auto merge of
rust-lang#118703 - Kobzol:bootstrap-config-unused, r=onur-ozkan
rust-lang@f1c5558edc Add ChangeInfo
record
rust-lang@ccbd88dc83 Remove unused
run_dsymutil and gpg_password_file config values
rust-lang@6badc0d840 Destructure TOML
configs
rust-lang@7e452c123c Auto merge of
rust-lang#118791 - saethlin:use-immediate-type, r=nikic
rust-lang@b9068315db Auto merge of
rust-lang#116952 - compiler-errors:lifetime_capture_rules_2024, r=TaKO8Ki
rust-lang@befd1eb4ec Auto merge of
rust-lang#116278 - Kobzol:bootstrap-lld-mode, r=albertlarsan68,petrochenkov
rust-lang@dc2f77aad6 Add (unstable)
documentation for --env command line option
rust-lang@d2b1f94f05 Add feature gate
test for --env flag
rust-lang@37d68093da Add ui tests for
--env option
rust-lang@486e55e547 Implement --env
compiler flag
rust-lang@53031b264e Review fixes
rust-lang@84f6130fe3 Auto merge of
rust-lang#118692 - surechen:remove_unused_imports, r=petrochenkov
rust-lang@4750e9de47 Produce an explicit
error when using a self-contained lld, but we don't add it to sysroot
rust-lang@ea769dbeb7 Add change tracker
entry
rust-lang@cbfe6327a1 Do not invoke
external lld to figure out thread flags in self-contained mode
rust-lang@50865745e1 Update
config.example.toml
rust-lang@40c3d351ad Use MCP510
rust-lang@48c1607bc6 Introduce LldMode
and generalize parsing of use-lld
rust-lang@d9f9e67bc1 Refactor rust(do)c
linker flags
rust-lang@b3c9ffdc77 Add is_msvc
function
rust-lang@c1a3919378 Auto merge of
rust-lang#118792 - naglis:fix-mutex-doc-typo, r=workingjubilee
rust-lang@42dfac5e08 Auto merge of
rust-lang#118788 - compiler-errors:const-pretty, r=fee1-dead
rust-lang@61afc9c928 Auto merge of
rust-lang#116949 - hamza1311:stablize-arc_unwrap_or_clone, r=dtolnay
rust-lang@c71c246876 Auto merge of
rust-lang#118550 - cjgillot:filecheck-const-prop, r=Mark-Simulacrum
rust-lang@40ae34194c remove redundant
imports
rust-lang@f7253f2317 Auto merge of
rust-lang#118787 - GuillaumeGomez:rollup-fj5wr3q, r=GuillaumeGomez
rust-lang@7d50a39763 Fix typo in
std::sync::Mutex example
rust-lang@8cd8d31369 Auto merge of
rust-lang#118069 - onur-ozkan:bypass_bootstrap_lock, r=Mark-Simulacrum
rust-lang@b0a580112b Use
immediate_backend_type when reading from a const alloc
rust-lang@afa35e90ef Print constness in
TraitPredPrintModifiersAndPath
rust-lang@7467c3a45c
s/const_effect/host_effect
rust-lang@f1bf874fb1 Don't print host
effect param in pretty path_generic_args
rust-lang@6860654d82 allow bypassing the
build directory lock
rust-lang@dd234696ed Rollup merge of
rust-lang#118782 - jyn514:powershell, r=ChrisDenton
rust-lang@034d73d6d7 Rollup merge of
rust-lang#118775 - Young-Flash:fix, r=compiler-errors
rust-lang@5b9e917b64 Rollup merge of
rust-lang#118774 - lcnr:region-refactor-uwu, r=compiler-errors
rust-lang@cc821d3ae6 Rollup merge of
rust-lang#118747 - Urgau:check-cfg-freebsd-cleanup, r=onur-ozkan
rust-lang@83e814f88c Rollup merge of
rust-lang#117966 - lxy19980601:safe_compilation_options, r=Mark-Simulacrum
rust-lang@2cf54e9f99 use & instead of
start-process in x.ps1
rust-lang@ef796db5f0 add test for
inductive cycle hangs
rust-lang@cb6984217f chore: add test case
for type with generic
rust-lang@0f40b6545d Remove extra
check-cfg handled by libc directly
rust-lang@803772e81d Enable new capture
rules by default on edition 2024
rust-lang@acba7efe1b Add test for
implicitly capturing late-bound var with new capture rules
rust-lang@0ad160a585 Add
lifetime_capture_rules_2024
rust-lang@3f8487a099 Add safe compilation
options
rust-lang@30a95b7c0a FileCheck
while_let_loops.
rust-lang@c00068e49f FileCheck
tuple_literal_propagation.
rust-lang@87522d0007 FileCheck
return_place.
rust-lang@a12027e128 FileCheck
switch_int.
rust-lang@19767eb7a6 FileCheck slice_len.
rust-lang@3e90c1b434 FileCheck
scalar_literal_propagation.
rust-lang@f3743aec51 FileCheck repeat.
rust-lang@343ef6a9cb FileCheck
reify_fn_ptr.
rust-lang@6baec3ccc2 FileCheck ref_deref.
rust-lang@c8c9207e4c FileCheck
read_immutable_static.
rust-lang@45dd5d6bf3 FileCheck
mutable_variable_unprop_assign.
rust-lang@6a8eea8f5b FileCheck
mutable_variable_aggregate_partial_read.
rust-lang@d91bb5074e FileCheck
mutable_variable_no_prop.
rust-lang@3e169abc1b FileCheck
mutable_variable_aggregate_mut_ref.
rust-lang@03c5ad1549 FileCheck
mutable_variable_aggregate.
rust-lang@ea9f968333 FileCheck
mutable_variable.
rust-lang@902a3e2e75 FileCheck
mult_by_zero.
rust-lang@8e9b912c4c FileCheck
issue_67019.
rust-lang@ce9b1e23a5 FileCheck
issue_66971.
rust-lang@218d8ccf43 FileCheck
inherit_overflow.
rust-lang@6086dd6766 FileCheck indirect.
rust-lang@bf5d114da8 FileCheck
discriminant.
rust-lang@043d29b58a FileCheck and rename
const_prop_fails_gracefully.
rust-lang@7f328d2a44 FileCheck
checked_add.
rust-lang@e6a1b77cd1 FileCheck cast.
rust-lang@b8f2f63931 FileCheck boxes.
rust-lang@3fc03948a8 FileCheck
boolean_identities.
rust-lang@e8e35c8127 FileCheck
bad_op_unsafe_oob_for_slices.
rust-lang@97f03cb898 FileCheck
bad_op_mod_by_zero.
rust-lang@0d5bc872a9 FileCheck
bad_op_div_by_zero.
rust-lang@9f01d9d1b6 FileCheck
array_index.
rust-lang@6564bac532 FileCheck aggregate.
rust-lang@378abbc604 FileCheck
address_of_pair.
rust-lang@540921e468 Stablize
arc_unwrap_or_clone
Co-authored-by: celinval celinval@users.noreply.github.com
Labels
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
This PR was explicitly merged by bors.
Operating system: Unix-like
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.