Fix: Properly set vendor in i686-win7-windows-msvc target by roblabla · Pull Request #119544 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In #118150 , setting the vendor field of the i686-win7-windows-msvc target was forgotten, preventing us from easily checking the target using cfg(target_vendor).

With this PR, we set the target vendor to "win7".

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 3, 2024

This comment has been minimized.

📌 Commit d9d23fa has been approved by Nilstrieb

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 3, 2024

fmease added a commit to fmease/rust that referenced this pull request

Jan 3, 2024

…rieb

Fix: Properly set vendor in i686-win7-windows-msvc target

In rust-lang#118150 , setting the vendor field of the i686-win7-windows-msvc target was forgotten, preventing us from easily checking the target using cfg(target_vendor).

With this PR, we set the target vendor to "win7".

Did i686-win7-windows-msvc make it into beta already? Should this be backported?

Yes, it did. A backport would be nice.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 3, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 3, 2024

Rollup merge of rust-lang#119544 - roblabla:new-win7-targets, r=Nilstrieb

Fix: Properly set vendor in i686-win7-windows-msvc target

In rust-lang#118150 , setting the vendor field of the i686-win7-windows-msvc target was forgotten, preventing us from easily checking the target using cfg(target_vendor).

With this PR, we set the target vendor to "win7".

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 7, 2024

…mulacrum

[beta] backport rollup

This PR backports: