Improved collapse_debuginfo attribute, added command-line flag by azhogin · Pull Request #119828 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation30 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@azhogin

Improved attribute collapse_debuginfo with variants: #[collapse_debuginfo=(no|external|yes)].
Added command-line flag for default behaviour.
Work-in-progress: will add more tests.

cc #100758

@rustbot

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 10, 2024

@WaffleLapkin

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 10, 2024

@azhogin

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@azhogin azhogin changed the titleImproved collapse_debuginfo attribute, added command-line flag (WIP) Improved collapse_debuginfo attribute, added command-line flag

Jan 14, 2024

@azhogin azhogin marked this pull request as ready for review

January 14, 2024 19:52

@azhogin

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 14, 2024

petrochenkov

@bors

This comment was marked as resolved.

@rust-log-analyzer

This comment has been minimized.

petrochenkov

@azhogin

@petrochenkov

Looks ready and CI is green.
@bors r+

@bors

📌 Commit 8507f51 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 17, 2024

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jan 17, 2024

@compiler-errors

…_improved_attr, r=petrochenkov

Improved collapse_debuginfo attribute, added command-line flag

Improved attribute collapse_debuginfo with variants: #[collapse_debuginfo=(no|external|yes)]. Added command-line flag for default behaviour. Work-in-progress: will add more tests.

cc rust-lang#100758

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 18, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 19, 2024

@bors

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 19, 2024

@rust-timer

Rollup merge of rust-lang#119828 - azhogin:azhogin/collapse_debuginfo_improved_attr, r=petrochenkov

Improved collapse_debuginfo attribute, added command-line flag

Improved attribute collapse_debuginfo with variants: #[collapse_debuginfo=(no|external|yes)]. Added command-line flag for default behaviour. Work-in-progress: will add more tests.

cc rust-lang#100758

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.