Avoid a collection and iteration on empty passes by blyxyas · Pull Request #120853 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Just some mini optimization I saw in the wild. This way, we avoid a collect and map on an empty passes. Honestly, I don't even think this is big enough of a change to make a benchmark, but I'd still like to see results.
Based on this book
r? @cjgillot
rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
📌 Commit 4ef1790 has been approved by cjgillot
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
next time, pls amend the commit with any formatter changes (or install the tidy hook in x.py setup)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Avoid a collection and iteration on empty passes
Just some mini optimization I saw in the wild. This way, we avoid a collect and map on an empty passes. Honestly, I don't even think this is big enough of a change to make a benchmark, but I'd still like to see results.
Based on this book
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#120584 (For a rigid projection, recursively look at the self type's item bounds to fix the
associated_type_boundsfeature) - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
- rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
- rust-lang#120629 (Move some test files)
- rust-lang#120846 (Update jobserver-rs to 0.1.28)
- rust-lang#120850 (ast_lowering: Fix regression in
use ::{}imports.) - rust-lang#120853 (Avoid a collection and iteration on empty passes)
Failed merges:
- rust-lang#120549 (modify alias-relate to also normalize ambiguous opaques)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#120584 (For a rigid projection, recursively look at the self type's item bounds to fix the
associated_type_boundsfeature) - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
- rust-lang#120629 (Move some test files)
- rust-lang#120846 (Update jobserver-rs to 0.1.28)
- rust-lang#120850 (ast_lowering: Fix regression in
use ::{}imports.) - rust-lang#120853 (Avoid a collection and iteration on empty passes)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.