Print kind of coroutine closure by compiler-errors · Pull Request #120896 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Make sure that we print "async closure" when we have an async closure, rather than calling it generically a "coroutine-closure".

Fixes #120886

r? oli-obk

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 10, 2024

This comment has been minimized.

📌 Commit 86ddb53 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 11, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#119213 (simd intrinsics: add simd_shuffle_generic and other missing intrinsics)
• rust-lang#120272 (Suppress suggestions in derive macro)
• rust-lang#120773 (large_assignments: Allow moves into functions)
• rust-lang#120874 (Take empty where bounds into account when suggesting predicates)
• rust-lang#120882 (interpret/write_discriminant: when encoding niched variant, ensure the stored value matches)
• rust-lang#120883 (interpret: rename ReadExternStatic → ExternStatic)
• rust-lang#120890 (Adapt llvm-has-rust-patches validation to take llvm-config into account.)
• rust-lang#120895 (don't skip coercions for types with errors)
• rust-lang#120896 (Print kind of coroutine closure)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 11, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#119213 (simd intrinsics: add simd_shuffle_generic and other missing intrinsics)
• rust-lang#120272 (Suppress suggestions in derive macro)
• rust-lang#120773 (large_assignments: Allow moves into functions)
• rust-lang#120874 (Take empty where bounds into account when suggesting predicates)
• rust-lang#120882 (interpret/write_discriminant: when encoding niched variant, ensure the stored value matches)
• rust-lang#120883 (interpret: rename ReadExternStatic → ExternStatic)
• rust-lang#120890 (Adapt llvm-has-rust-patches validation to take llvm-config into account.)
• rust-lang#120895 (don't skip coercions for types with errors)
• rust-lang#120896 (Print kind of coroutine closure)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 11, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#119213 (simd intrinsics: add simd_shuffle_generic and other missing intrinsics)
• rust-lang#120272 (Suppress suggestions in derive macro)
• rust-lang#120773 (large_assignments: Allow moves into functions)
• rust-lang#120874 (Take empty where bounds into account when suggesting predicates)
• rust-lang#120882 (interpret/write_discriminant: when encoding niched variant, ensure the stored value matches)
• rust-lang#120883 (interpret: rename ReadExternStatic → ExternStatic)
• rust-lang#120890 (Adapt llvm-has-rust-patches validation to take llvm-config into account.)
• rust-lang#120895 (don't skip coercions for types with errors)
• rust-lang#120896 (Print kind of coroutine closure)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 11, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#119213 (simd intrinsics: add simd_shuffle_generic and other missing intrinsics)
• rust-lang#120272 (Suppress suggestions in derive macro)
• rust-lang#120773 (large_assignments: Allow moves into functions)
• rust-lang#120874 (Take empty where bounds into account when suggesting predicates)
• rust-lang#120882 (interpret/write_discriminant: when encoding niched variant, ensure the stored value matches)
• rust-lang#120883 (interpret: rename ReadExternStatic → ExternStatic)
• rust-lang#120890 (Adapt llvm-has-rust-patches validation to take llvm-config into account.)
• rust-lang#120895 (don't skip coercions for types with errors)
• rust-lang#120896 (Print kind of coroutine closure)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 11, 2024

Rollup merge of rust-lang#120896 - compiler-errors:coro-closure-kind, r=oli-obk

Print kind of coroutine closure

Make sure that we print "async closure" when we have an async closure, rather than calling it generically a "coroutine-closure".

Fixes rust-lang#120886

r? oli-obk

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.